Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Sriov common chains (#463)" #466

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Revert "Sriov common chains (#463)" #466

merged 1 commit into from
Sep 20, 2020

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: denis-tingajkin [email protected]

This reverts commit 0b749c7.

  1. macaddr is not consistent with https://github.com/networkservicemesh/sdk-vppagent/blob/master/pkg/networkservice/connectioncontext/ethernetcontext/macaddress/server.go#L17 by name
  2. macaddr should be implemented by each platform(We don't need common macaddr).
  3. It seems to me SDK should not contain 'common sriov stuff'.

@denis-tingaikin
Revert "Sriov common chains (networkservicemesh#463)"
394160d 
This reverts commit 0b749c7.

Signed-off-by: denis-tingajkin <[email protected]>
@edwarnicke edwarnicke merged commit acdc0f4 into networkservicemesh:master Sep 20, 2020
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 20, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a3428ce 
…k@master networkservicemesh/sdk#466

networkservicemesh/sdk PR link: networkservicemesh/sdk#466

networkservicemesh/sdk commit message:
commit acdc0f408c7252647b695cd3801cc255b9d79555
Author: Denis Tingaikin <[email protected]>
Date:   Mon Sep 21 00:36:35 2020 +0700

    Revert "Sriov common chains (#463)" (#466)

    This reverts commit 0b749c774ca94506e86e5554e1a6621203ee71c1.

    Signed-off-by: denis-tingajkin <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 20, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e42c127 
…k@master networkservicemesh/sdk#466

networkservicemesh/sdk PR link: networkservicemesh/sdk#466

networkservicemesh/sdk commit message:
commit acdc0f408c7252647b695cd3801cc255b9d79555
Author: Denis Tingaikin <[email protected]>
Date:   Mon Sep 21 00:36:35 2020 +0700

    Revert "Sriov common chains (#463)" (#466)

    This reverts commit 0b749c774ca94506e86e5554e1a6621203ee71c1.

    Signed-off-by: denis-tingajkin <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 20, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
179fdf8 
…k@master networkservicemesh/sdk#466

networkservicemesh/sdk PR link: networkservicemesh/sdk#466

networkservicemesh/sdk commit message:
commit acdc0f408c7252647b695cd3801cc255b9d79555
Author: Denis Tingaikin <[email protected]>
Date:   Mon Sep 21 00:36:35 2020 +0700

    Revert "Sriov common chains (#463)" (#466)

    This reverts commit 0b749c774ca94506e86e5554e1a6621203ee71c1.

    Signed-off-by: denis-tingajkin <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 20, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2bf897d 
…k@master networkservicemesh/sdk#466

networkservicemesh/sdk PR link: networkservicemesh/sdk#466

networkservicemesh/sdk commit message:
commit acdc0f408c7252647b695cd3801cc255b9d79555
Author: Denis Tingaikin <[email protected]>
Date:   Mon Sep 21 00:36:35 2020 +0700

    Revert "Sriov common chains (#463)" (#466)

    This reverts commit 0b749c774ca94506e86e5554e1a6621203ee71c1.

    Signed-off-by: denis-tingajkin <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-vppagent that referenced this pull request Sep 20, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
01e2c79 
…k@master networkservicemesh/sdk#466

networkservicemesh/sdk PR link: networkservicemesh/sdk#466

networkservicemesh/sdk commit message:
commit acdc0f408c7252647b695cd3801cc255b9d79555
Author: Denis Tingaikin <[email protected]>
Date:   Mon Sep 21 00:36:35 2020 +0700

    Revert "Sriov common chains (#463)" (#466)

    This reverts commit 0b749c774ca94506e86e5554e1a6621203ee71c1.

    Signed-off-by: denis-tingajkin <[email protected]>

Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke