vl3 chain element that resets IPContext configuration depending on dst and src addresses #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
NikitaSkrynnik
changed the title
NikitaSkrynnik
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
=======================================
Coverage ? 67.25%
=======================================
Files ? 261
Lines ? 12371
Branches ? 0
=======================================
Hits ? 8320
Misses ? 3529
Partials ? 522 ☔ View full report in Codecov by Sentry. |
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
NikitaSkrynnik
force-pushed
the
strict-vl3-ipam
branch
from
ddc3978
to
beb9fc2
Compare
Signed-off-by: NikitaSkrynnik <[email protected]>
NikitaSkrynnik
force-pushed
the
strict-vl3-ipam
branch
from
1047482
to
42c291f
Compare
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
denis-tingaikin
approved these changes
Mar 18, 2024
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
glazychev-art
approved these changes
Mar 19, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Mar 19, 2024
…k@main PR link: networkservicemesh/sdk#1588 Commit: 3027f90 Author: Nikita Skrynnik Date: 2024-03-19 16:01:00 +0700 Message: - vl3 chain element that resets IPContext configuration depending on dst and src addresses (#1588) * add strict ipam for vl3 networks Signed-off-by: NikitaSkrynnik <[email protected]> * fix chain element Signed-off-by: NikitaSkrynnik <[email protected]> * rename chain element Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * apply review comments Signed-off-by: NikitaSkrynnik <[email protected]> * remove all channels, use ipPools only Signed-off-by: NikitaSkrynnik <[email protected]> * rerun CI Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix review comments Signed-off-by: NikitaSkrynnik <[email protected]> * fix go linter issues Signed-off-by: NikitaSkrynnik <[email protected]> * revert changes Signed-off-by: NikitaSkrynnik <[email protected]> * revert some changes + add mutex to ContainsNetString Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new chain element that resets client's IPContext configuration if its dst and src addresses are from another vl3 subnetwork
Issue link
networkservicemesh/cmd-nse-vl3-vpp#289
How Has This Been Tested?
Types of changes