Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestRecvfdClosesSingleFile #1559

Merged

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Nov 22, 2023

Issue link

#1525

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review November 22, 2023 07:52
Signed-off-by: NikitaSkrynnik <[email protected]>
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@7e78948). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1559   +/-   ##
=======================================
  Coverage        ?   66.91%           
=======================================
  Files           ?      259           
  Lines           ?    12327           
  Branches        ?        0           
=======================================
  Hits            ?     8248           
  Misses          ?     3560           
  Partials        ?      519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: NikitaSkrynnik <[email protected]>
@denis-tingaikin denis-tingaikin merged commit 9c02db4 into networkservicemesh:main Dec 26, 2023
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Dec 26, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 30, 2023
…k@main

PR link: networkservicemesh/sdk#1559

Commit: 9c02db4
Author: Nikita Skrynnik
Date: 2023-12-26 18:56:04 +1100
Message:
  - Fix TestRecvfdClosesSingleFile (#1559)
* Fix TestRecvfdClosesSingleFile

Signed-off-by: NikitaSkrynnik <[email protected]>

* run test 5000 times

Signed-off-by: NikitaSkrynnik <[email protected]>

* add begin server + cleanup

Signed-off-by: NikitaSkrynnik <[email protected]>

* fix golang linter

Signed-off-by: NikitaSkrynnik <[email protected]>

---------

Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants