p2pipam: Add the ability to recover IP addresses #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
recover_ip
branch
from
6ad84fa
to
d3e52c6
Compare
| } | ||
|
|
||
| // PullIP - returns requested IP address from the pool | ||
| func (tree *IPPool) PullIP(ip net.IP, exclude ...*IPPool) (*net.IPNet, error) { |
There was a problem hiding this comment.
I'm not quite following PullIP(...) operation. Could you clarify a bit why do we need it?
There was a problem hiding this comment.
This was added for consistency with other pool methods - most of them have 2 versions: Name(...) and NameString(...)
denis-tingaikin
approved these changes
Sep 29, 2022
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Sep 29, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
This was referenced Sep 29, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Oct 2, 2022
…k@main PR link: networkservicemesh/sdk#1360 Commit: 6d73fda Author: Artem Glazychev Date: 2022-09-30 04:00:17 +0700 Message: - p2pipam: Add the ability to recover IP addresses (#1360) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev [email protected]
Description
Add the ability to recover IP addresses (healing case)
Issue link
#1358
How Has This Been Tested?
Types of changes