Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more logging for vni chain elements #1174

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/networkservice/common/mechanisms/vxlan/vni/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ import (
"context"
"net"

"github.com/networkservicemesh/sdk/pkg/tools/log"

"github.com/golang/protobuf/ptypes/empty"
"google.golang.org/grpc"

Expand Down Expand Up @@ -57,6 +59,12 @@ func (v *vniClient) Request(ctx context.Context, request *networkservice.Network
if mech := vxlan.ToMechanism(m); mech != nil {
mech.SetSrcIP(v.tunnelIP)
mech.SetSrcPort(v.tunnelPort)

log.FromContext(ctx).
WithField("VNIclient", "request").
WithField("mechSrcIp", mech.SrcIP()).
WithField("mechSrcPort", mech.SrcPort()).
Debugf("set mechanism src")
}
}
return next.Client(ctx).Request(ctx, request, opts...)
Expand Down
25 changes: 25 additions & 0 deletions pkg/networkservice/common/mechanisms/vxlan/vni/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import (
"net"
"sync"

"github.com/networkservicemesh/sdk/pkg/tools/log"

"github.com/golang/protobuf/ptypes/empty"

"github.com/networkservicemesh/api/pkg/api/networkservice"
Expand Down Expand Up @@ -56,30 +58,43 @@ func NewServer(tunnelIP net.IP, options ...Option) networkservice.NetworkService
}

func (v *vniServer) Request(ctx context.Context, request *networkservice.NetworkServiceRequest) (*networkservice.Connection, error) {
logger := log.FromContext(ctx).WithField("VNIserver", "request")

mechanism := vxlan.ToMechanism(request.GetConnection().GetMechanism())
if mechanism == nil {
logger.Debugf("mechanism is not vxlan")
return next.Server(ctx).Request(ctx, request)
}
mechanism.SetDstIP(v.tunnelIP)
mechanism.SetDstPort(v.tunnelPort)

logger.WithField("mechanism.DstIP", mechanism.DstIP()).WithField("mechanism.DstPort", mechanism.DstPort()).Debugf("set mechanism dst")

k := vniKey{
srcIPString: mechanism.SrcIP().String(),
vni: mechanism.VNI(),
}

// If we already have a VNI, make sure we remember it, and go on
if k.vni != 0 && mechanism.SrcIP() != nil {
_, _ = v.Map.LoadOrStore(k, &k)
_, loaded := loadOrStore(ctx, metadata.IsClient(v), k.vni)

logger.WithField("vni", k.vni).Debugf("loadOrStore vni in metadata")

conn, err := next.Server(ctx).Request(ctx, request)
if err != nil && !loaded {
delete(ctx, metadata.IsClient(v))
v.Map.Delete(k)

logger.WithField("vni", k.vni).Errorf("error returned from request, deleting vni. err=%v", err.Error())
}
return conn, err
}

if vni, ok := load(ctx, metadata.IsClient(v)); ok {
mechanism.SetVNI(vni)
logger.WithField("vni", vni).Debugf("vni loaded from metadata")
} else {
for {
// Generate a random VNI (appropriately odd or even)
Expand All @@ -92,6 +107,7 @@ func (v *vniServer) Request(ctx context.Context, request *networkservice.Network
if _, ok := v.Map.LoadOrStore(k, &k); !ok {
mechanism.SetVNI(k.vni)
store(ctx, metadata.IsClient(v), k.vni)
logger.WithField("vni", k.vni).Debugf("vni generated and stored in metadata")
break
}
}
Expand All @@ -101,6 +117,8 @@ func (v *vniServer) Request(ctx context.Context, request *networkservice.Network
if err != nil {
delete(ctx, metadata.IsClient(v))
v.Map.Delete(k)

logger.WithField("vniKey.vni", k.vni).Errorf("error returned from request, deleting vni. err=%v", err.Error())
}
return conn, err
}
Expand All @@ -111,9 +129,16 @@ func (v *vniServer) Close(ctx context.Context, conn *networkservice.Connection)
srcIPString: mechanism.SrcIP().String(),
vni: mechanism.VNI(),
}

if k.vni != 0 && mechanism.SrcIP() != nil {
delete(ctx, metadata.IsClient(v))
v.Map.LoadAndDelete(k)

log.FromContext(ctx).
WithField("VNIserver", "close").
WithField("vniKey.srcIPString", k.srcIPString).
WithField("vniKey.vni", k.vni).
Debugf("vniKey deleted")
}
}
return next.Server(ctx).Close(ctx, conn)
Expand Down