Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework client, connect, to simplify and prepare for simpler healing. #1083

Merged
merged 20 commits into from
Oct 13, 2021
Merged

Rework client, connect, to simplify and prepare for simpler healing. #1083

merged 20 commits into from
Oct 13, 2021

Commits on Sep 29, 2021

  1. Rework client, connect, to simplify and prepare for simpler healing. 

    Previously we had a single 'client' per grpc.ClientConnInterface.
This created a lot of complexity, particularly in connect.

This rework of client moves to a single 'client' that can handle
multiple grpc.ClientConnInterfaces.

This vastly simplified both the client chain and connect chain.

Finally, heal has been temporarily removed in preparation for a rework
of heal focused on back propogating Connection 'DOWN' events via
monitor.  The net net at the end of the process should be:

1)  Refresh is only originated by actual clients, not the 'client' part
of passthrough NSEs
2)  Heal will only be originated by actual clients, not the 'client' part
pf passthrough NSEs.

Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    d5dc731 View commit details
    Browse the repository at this point in the history

  2. Response to comment networkservicemesh#1083 (comment) 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    444b008 View commit details
    Browse the repository at this point in the history

  3. Response to comment networkservicemesh#1083 (comment) 

    and also networkservicemesh#1083 (comment)

Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    821b5f2 View commit details
    Browse the repository at this point in the history

  4. Response to comment networkservicemesh#1083 (comment) 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    ee9119e View commit details
    Browse the repository at this point in the history

  5. Switch to dial per request 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    baa307e View commit details
    Browse the repository at this point in the history

  6. Rebased and adapted to testing. 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    a58c707 View commit details
    Browse the repository at this point in the history

  7. Response to comment networkservicemesh#1083 (comment) 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    c2ffe5e View commit details
    Browse the repository at this point in the history

  8. Response to comments. 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    b1e3eab View commit details
    Browse the repository at this point in the history

  9. Fix golangci-lint errors. 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    214ed2a View commit details
    Browse the repository at this point in the history

  10. Fix to test goroutine leak checking. 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    7d62553 View commit details
    Browse the repository at this point in the history

  11. Response to comment networkservicemesh#1083 (comment) 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    03896d7 View commit details
    Browse the repository at this point in the history

  12. Fix improper go routine leak checks in tests. 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    74f2fb2 View commit details
    Browse the repository at this point in the history

  13. Rework dial chain element to handle cleanup on close correctly. 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f9925a4 View commit details
    Browse the repository at this point in the history

  14. Restored grpc.WaitForReady in sandbox 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    4451e69 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Response to comment https://github.com/networkservicemesh/sdk/pull/10… 

    …83/files/4451e69ec246e30dde13a60d9f86efeb8a680766#r719022909

Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    cc5e48f View commit details
    Browse the repository at this point in the history

  2. Response to comment https://github.com/networkservicemesh/sdk/pull/10… 

    …83/files/4451e69ec246e30dde13a60d9f86efeb8a680766#r719023399

Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Sep 30, 2021
    1 Configuration menu
    Copy the full SHA
    af236c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Response to networkservicemesh#1083 (comment) 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    749c709 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Introducing monitor client chain element 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    53ffd0c View commit details
    Browse the repository at this point in the history

  2. Response to comment networkservicemesh#1083 (comment) 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    b40600b View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Response to networkservicemesh#1083 (comment) 

    Signed-off-by: Ed Warnicke <[email protected]>
    @edwarnicke
    edwarnicke committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    bebe546 View commit details
    Browse the repository at this point in the history