Fix chain elements init function #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
sync_once_fix
branch
from
f3cddab
to
fd36f99
Compare
denis-tingaikin
requested changes
Feb 3, 2022
pkg/networkservice/up/server.go
Outdated
| u.initErr = initFunc(ctx, u.vppConn) | ||
| }) | ||
| return u.initErr | ||
| if !u.inited.Load() { |
There was a problem hiding this comment.
This looks not thread-safe. A few goroutines could read u.inited as a false and block on the u.initMutex.
There was a problem hiding this comment.
Probably we could add something like this https://go.dev/play/p/f2J7aioP59W and add this into sdk/tools as a common solution for chain elements with init functions
There was a problem hiding this comment.
As an alternative, we also could use a personal Executor.
There was a problem hiding this comment.
@denis-tingaikin
I like the idea about extended sync.Once and add it to sdk/tools.
Prepared PR: networkservicemesh/sdk#1224
There was a problem hiding this comment.
made it inline
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
sync_once_fix
branch
from
fd36f99
to
600ec63
Compare
denis-tingaikin
approved these changes
Feb 4, 2022
|
This problem is actual. So merging. @edwarnicke Please have a look at networkservicemesh/sdk#1224 this can a bit simplify these changes. |
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Feb 4, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#506 Commit: 807bc2b Author: Artem Glazychev Date: 2022-02-04 17:12:04 +0700 Message: - Fix chain elements init function (#506) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Feb 4, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#506 Commit: 807bc2b Author: Artem Glazychev Date: 2022-02-04 17:12:04 +0700 Message: - Fix chain elements init function (#506) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Feb 4, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#506 Commit: 807bc2b Author: Artem Glazychev Date: 2022-02-04 17:12:04 +0700 Message: - Fix chain elements init function (#506) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Feb 4, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#506 Commit: 807bc2b Author: Artem Glazychev Date: 2022-02-04 17:12:04 +0700 Message: - Fix chain elements init function (#506) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Feb 4, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#506 Commit: 807bc2b Author: Artem Glazychev Date: 2022-02-04 17:12:04 +0700 Message: - Fix chain elements init function (#506) Signed-off-by: NSMBot <[email protected]>
This was referenced Feb 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: networkservicemesh/deployments-k8s#2800
Motivation
If context was canceled (e.g by timeout) in the middle of the chain, and the next chain element has
initfunction withsync.Once- we have no chance to callinitagain. We store the error and all new Requests will fail with that error.Solution
Call the
initfunction only the first time, OR if the first call returned an error.Signed-off-by: Artem Glazychev [email protected]