Policy Route: Select table ID based on routes and rules #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If flushing the table in delRule fails, the table with the stored id and the connection id will still contain the table id and the rule will still be existing. Selecting a table ID based on routes and rules prevents conflicts to happen. Signed-off-by: Lionel Jouin <[email protected]>
denis-tingaikin
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
LGTM.
@LionelJouin It seems like this fix is going to be available in v1.12.0. Is it fine for you, or should we release a forwarder based on this patch?
|
Thank you @denis-tingaikin. |
We prefer to get a forwarder on top of v1.11.1 because v1.12.0 is too late. |
|
@szvincze OK, I think it's possible to include this patch for forwader-vpp. I'll add it if integration-k8s-kind passes CI based on this patch. |
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Nov 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#629 Commit: ba96cf9 Author: Denis Tingaikin Date: 2023-11-18 16:50:04 +0300 Message: - Merge pull request #629 from Nordix/fix-table-id-selection-policy-routes Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Nov 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#629 Commit: ba96cf9 Author: Denis Tingaikin Date: 2023-11-18 16:50:04 +0300 Message: - Merge pull request #629 from Nordix/fix-table-id-selection-policy-routes Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
Nov 18, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#629 Commit: ba96cf9 Author: Denis Tingaikin Date: 2023-11-18 16:50:04 +0300 Message: - Merge pull request #629 from Nordix/fix-table-id-selection-policy-routes Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If flushing the table in delRule fails, the table with the stored id and the connection id will still contain the table id and the rule will still be existing.
Selecting a table ID based on routes and rules prevents conflicts to happen.