Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deletion of IPv6 default policy routes #627

Merged

Conversation

LionelJouin
Copy link
Member

On Deletion, the default route got its dst attribute replaced with an empty IPv4 address even with IPv6.

@LionelJouin LionelJouin added the bug Something isn't working label Nov 16, 2023
On Deletion, the default route got its dst attribute replaced with an
empty IPv4 address even with IPv6.

Signed-off-by: Lionel Jouin <[email protected]>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denis-tingaikin denis-tingaikin merged commit f8971e7 into networkservicemesh:main Nov 18, 2023
12 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-nse-l7-proxy that referenced this pull request Nov 18, 2023
…k-kernel@main

PR link: networkservicemesh/sdk-kernel#627

Commit: f8971e7
Author: Denis Tingaikin
Date: 2023-11-18 16:50:38 +0300
Message:
  - Merge pull request #627 from Nordix/fix-ipv6-policy-route
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-sriov that referenced this pull request Nov 18, 2023
…k-kernel@main

PR link: networkservicemesh/sdk-kernel#627

Commit: f8971e7
Author: Denis Tingaikin
Date: 2023-11-18 16:50:38 +0300
Message:
  - Merge pull request #627 from Nordix/fix-ipv6-policy-route
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Nov 18, 2023
…k-kernel@main

PR link: networkservicemesh/sdk-kernel#627

Commit: f8971e7
Author: Denis Tingaikin
Date: 2023-11-18 16:50:38 +0300
Message:
  - Merge pull request #627 from Nordix/fix-ipv6-policy-route
Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants