IP address and policy removal on connection update #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Based on interfaces addresses, IPs in IPContext are filtered: to add/to removed Signed-off-by: Lionel Jouin <[email protected]>
* Based on memory, Policies are filtered: to add/to removed * Doesn't support forwarder resiliency. If the forwarder restart, the existing policy routes are forgotten Signed-off-by: Lionel Jouin <[email protected]>
* Flush table * Remove empty ip rule entries on close * Remove unused code Signed-off-by: Lionel Jouin <[email protected]>
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
issue-426
branch
from
1ee03bb
to
982980d
Compare
|
@LionelJouin @denis-tingaikin @edwarnicke @NikitaSkrynnik This is continuation of: #433 @LionelJouin Could you please check, if this solves your problems? |
denis-tingaikin
approved these changes
Mar 25, 2022
denis-tingaikin
requested review from
LionelJouin,
Chunosov,
edwarnicke and
NikitaSkrynnik
LionelJouin
reviewed
Mar 25, 2022
| delete(ps, tableID) | ||
| tableIDs.Store(conn.GetId(), ps) | ||
| } | ||
| if len(ps) == 0 { |
There was a problem hiding this comment.
I think this is no longer needed (if len(ps) == 0)
There was a problem hiding this comment.
Yes, thank you. I simplified a little
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
issue-426
branch
from
87e623f
to
3591e49
Compare
LionelJouin
approved these changes
Mar 25, 2022
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Mar 25, 2022
…k-kernel@main PR link: networkservicemesh/sdk-kernel#437 Commit: 0ca41e9 Author: Denis Tingaikin Date: 2022-03-25 19:32:57 +0300 Message: - Merge pull request #437 from glazychev-art/issue-426 Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Mar 25, 2022
…k-kernel@main PR link: networkservicemesh/sdk-kernel#437 Commit: 0ca41e9 Author: Denis Tingaikin Date: 2022-03-25 19:32:57 +0300 Message: - Merge pull request #437 from glazychev-art/issue-426 Signed-off-by: NSMBot <[email protected]>
This was referenced Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сontinuation of: #433
Signed-off-by: Artem Glazychev [email protected]