Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createpod chain element should be able support go-template based pod templates #352

Closed
denis-tingaikin opened this issue May 9, 2022 · 0 comments · Fixed by #353
Closed
Labels
good first issue Good for newcomers

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented May 9, 2022

Description

We defently interested in support this kind of deployments:

---
apiVersion: apps/v1
kind: Pod
metadata:
  name:  {{ (index .Connection.Path.PathSegments 0).Name }}
  labels: {{ .Connection.Labels }}

This adds flexibility to autoscale nse and it could be used in more interesting scenarios such like NSM+Application Service Mesh

Solution

  1. Make this https://github.com/networkservicemesh/sdk-k8s/blob/main/pkg/networkservice/common/createpod/server.go#L44 to string

  2. Process the template with Connection values here https://github.com/networkservicemesh/sdk-k8s/blob/main/pkg/networkservice/common/createpod/server.go#L134

  3. Make sure that current autoscale scenario is fine

@denis-tingaikin denis-tingaikin added the good first issue Good for newcomers label May 9, 2022
@denis-tingaikin denis-tingaikin changed the title createpod chain element should able to support go-template based pod templates createpod chain element should be able to support go-template based pod templates May 9, 2022
denis-tingaikin added a commit to denis-tingaikin/sdk-k8s that referenced this issue May 11, 2022
Signed-off-by: denis-tingaikin <[email protected]>
@denis-tingaikin denis-tingaikin changed the title createpod chain element should be able to support go-template based pod templates createpod chain element should be able support go-template based pod templates May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant