Update from update/networkservicemesh/sdk #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 93d252947219d952fd428e98e86e63ea17550579 Author: Uzlov Danil <[email protected]> Date: Tue May 11 21:22:51 2021 +0700 Add onidle chain element (#908) * add endpointtimeout chain element Signed-off-by: Danil Uzlov <[email protected]> * fix TestEndpointTimeout_ContextCancel instability Signed-off-by: Danil Uzlov <[email protected]> * make endpointTimeoutServer track connections, fix concurrency issues Signed-off-by: Danil Uzlov <[email protected]> * rename package endpointtimeout to idlenotifier Signed-off-by: Danil Uzlov <[email protected]> * fix formatting Signed-off-by: Danil Uzlov <[email protected]> * add HoldingActiveRequest test, clean code Signed-off-by: Danil Uzlov <[email protected]> * fix race in *endpointTimeoutServer) Signed-off-by: Danil Uzlov <[email protected]> * add TestIdleNotifier_FailedRequest Signed-off-by: Danil Uzlov <[email protected]> * fix missing error check Signed-off-by: Danil Uzlov <[email protected]> * make idlenotifier.notify action argument mandatory Signed-off-by: Danil Uzlov <[email protected]> * rename package idlenotifier to onidle Signed-off-by: Danil Uzlov <[email protected]> * fix TestIdleNotifier_ContextCancel instability Signed-off-by: Danil Uzlov <[email protected]> * clean code Signed-off-by: Danil Uzlov <[email protected]> * fix race in onIdleServer Signed-off-by: Danil Uzlov <[email protected]> * fix timer leak Signed-off-by: Danil Uzlov <[email protected]> * use require.Eventually + goleak.Find instead of time.Sleep in TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov <[email protected]> * remove excessive removeConnection call Signed-off-by: Danil Uzlov <[email protected]> * use simple map instead of sync.Map in onIdleServer Signed-off-by: Danil Uzlov <[email protected]> * adjuct comments Signed-off-by: Danil Uzlov <[email protected]> * refactor timer handling Signed-off-by: Danil Uzlov <[email protected]> * add TestIdleNotifier_RequestAfterExpire test Signed-off-by: Danil Uzlov <[email protected]> * remove unneeded check from TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov <[email protected]> * fix non-american "cancelled" spelling error Signed-off-by: Danil Uzlov <[email protected]> * add extra check for context error Signed-off-by: Danil Uzlov <[email protected]> * increase check timeout from 50ms to 100ms Signed-off-by: Danil Uzlov <[email protected]> * extract notify callback to be not under the mutex Signed-off-by: Danil Uzlov <[email protected]> * apply suggestions from code review Signed-off-by: Danil Uzlov <[email protected]> Signed-off-by: NSMBot <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 0ad523e Author: NSMBot [email protected] Date: Tue May 11 14:23:26 2021 +0000 Update go.mod and go.sum to latest version from networkservicemesh/sdk@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 93d252947219d952fd428e98e86e63ea17550579 Author: Uzlov Danil [email protected] Date: Tue May 11 21:22:51 2021 +0700 Add onidle chain element (#908) Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test add endpointtimeout chain element Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix TestEndpointTimeout_ContextCancel instability Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test make endpointTimeoutServer track connections, fix concurrency issues Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test rename package endpointtimeout to idlenotifier Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix formatting Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test add HoldingActiveRequest test, clean code Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix race in *endpointTimeoutServer) Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test add TestIdleNotifier_FailedRequest Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix missing error check Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test make idlenotifier.notify action argument mandatory Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test rename package idlenotifier to onidle Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix TestIdleNotifier_ContextCancel instability Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test clean code Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix race in onIdleServer Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix timer leak Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test use require.Eventually + goleak.Find instead of time.Sleep in TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test remove excessive removeConnection call Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test use simple map instead of sync.Map in onIdleServer Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test adjuct comments Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test refactor timer handling Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test add TestIdleNotifier_RequestAfterExpire test Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test remove unneeded check from TestIdleNotifier_ContextCancel Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix non-american "cancelled" spelling error Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test add extra check for context error Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test increase check timeout from 50ms to 100ms Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test extract notify callback to be not under the mutex Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test apply suggestions from code review Signed-off-by: Danil Uzlov [email protected] Signed-off-by: NSMBot [email protected]