Update from update/networkservicemesh/sdk #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit ef04aec9a3cd4abc14d580463f33e911e123c9c8 Author: Uzlov Danil <[email protected]> Date: Wed Apr 28 19:35:32 2021 +0700 Fix check for canceled grpc conn in connectServer (#867) * add test that catches connect server neddlessly recreating clients Signed-off-by: Danil Uzlov <[email protected]> * add flag for error Signed-off-by: Danil Uzlov <[email protected]> * add leaks check to connect CancelDuringRequest test Signed-off-by: Danil Uzlov <[email protected]> * use errors.Is instead of direct comparison in connect server Signed-off-by: Danil Uzlov <[email protected]> * run go mod tidy Signed-off-by: Danil Uzlov <[email protected]> * fix linter warning Signed-off-by: Danil Uzlov <[email protected]> * use context as error flag instead of atomic Signed-off-by: Danil Uzlov <[email protected]> * clean code in connect server cancel test Signed-off-by: Danil Uzlov <[email protected]> Signed-off-by: NSMBot <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit bb0aeaa Author: NSMBot [email protected] Date: Wed Apr 28 12:35:56 2021 +0000 Update go.mod and go.sum to latest version from networkservicemesh/sdk@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit ef04aec9a3cd4abc14d580463f33e911e123c9c8 Author: Uzlov Danil [email protected] Date: Wed Apr 28 19:35:32 2021 +0700 Fix check for canceled grpc conn in connectServer (#867) Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test add test that catches connect server neddlessly recreating clients Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test add flag for error Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test add leaks check to connect CancelDuringRequest test Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test use errors.Is instead of direct comparison in connect server Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test run go mod tidy Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test fix linter warning Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test use context as error flag instead of atomic Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md code-of-conduct.md go.mod go.sum internal local main.go staticcheck.conf test clean code in connect server cancel test Signed-off-by: Danil Uzlov [email protected] Signed-off-by: NSMBot [email protected]