Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from update/networkservicemesh/sdk #3

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Update from update/networkservicemesh/sdk #3

merged 1 commit into from
Oct 20, 2020

Conversation

nsmbot
Copy link
Contributor

@nsmbot nsmbot commented Oct 20, 2020

commit 5a40ce0

Update go.mod and go.sum to latest version from networkservicemesh/sd…
5a40ce0 
…k@master networkservicemesh/sdk#548

networkservicemesh/sdk PR link: networkservicemesh/sdk#548

networkservicemesh/sdk commit message:
commit 8b0bd573228d24958ad9e74f643d083709e81844
Author: Ed Warnicke <[email protected]>
Date:   Tue Oct 20 16:03:21 2020 -0500

    Explicitely close files for recvfd client *after* they don't matter. (#548)

    Previous we were allowing the recvfd files to be closed by their
    finalizer and the GC.

    This sometimes led to premature closing of files leading to errors like:

    networkservicemesh/cmd-forwarder-vppagent#187

    'Delete' case.  This fixes that by closing the files only after the
    ctx has is Done.

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
@github-actions github-actions bot merged commit 3e51f52 into master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nsmbot