Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister vl3 NSE on termination #292

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Feb 1, 2024

Description

Unregister NSE on termination so it deletes itself from the registry

Issue

#289

@NikitaSkrynnik NikitaSkrynnik changed the title Unregister vl3 NSE ctx.Done() Unregister vl3 NSE on termination Feb 1, 2024
@NikitaSkrynnik NikitaSkrynnik force-pushed the unregister branch 2 times, most recently from b38add4 to ad9c24c Compare February 1, 2024 09:08
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
@denis-tingaikin denis-tingaikin merged commit 68104f3 into networkservicemesh:main Feb 1, 2024
12 checks passed
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Feb 1, 2024
…d-nse-vl3-vpp@main

PR link: networkservicemesh/cmd-nse-vl3-vpp#292

Commit: 68104f3
Author: Denis Tingaikin
Date: 2024-02-01 13:42:16 +0300
Message:
  - Merge pull request #292 from NikitaSkrynnik/unregister
Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants