Update from update/networkservicemesh/sdk #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 2f267b7a5b1bcf896a579564e91c6a33ed80c37b Author: Uzlov Danil <[email protected]> Date: Tue May 4 16:23:47 2021 +0700 Fix Test_WatchFile instability (#886) * enable testing for WatchFile Signed-off-by: Danil Uzlov <[email protected]> * add checks into watchFile test Signed-off-by: Danil Uzlov <[email protected]> * add proper checks for PathError Signed-off-by: Danil Uzlov <[email protected]> * use unique path for every test attempt Signed-off-by: Danil Uzlov <[email protected]> * clean error checking code Signed-off-by: Danil Uzlov <[email protected]> * exclude ubuntu and macos from testing Signed-off-by: Danil Uzlov <[email protected]> * retry mkdir on failure Signed-off-by: Danil Uzlov <[email protected]> * reenable ubuntu and macos testing Signed-off-by: Danil Uzlov <[email protected]> * add extra info for macos debuging Signed-off-by: Danil Uzlov <[email protected]> * print each event Signed-off-by: Danil Uzlov <[email protected]> * mitigate macos inconsistency Signed-off-by: Danil Uzlov <[email protected]> * test Signed-off-by: Danil Uzlov <[email protected]> * test Signed-off-by: Danil Uzlov <[email protected]> * add more debug logs Signed-off-by: Danil Uzlov <[email protected]> * clean code Signed-off-by: Danil Uzlov <[email protected]> * remove sleep Signed-off-by: Danil Uzlov <[email protected]> * revert from context timeout to timeout per event Signed-off-by: Danil Uzlov <[email protected]> * enable all tests Signed-off-by: Danil Uzlov <[email protected]> * clean code Signed-off-by: Danil Uzlov <[email protected]> * extract constant for macos-specific behaviour handling Signed-off-by: Danil Uzlov <[email protected]> * refactor Test_WatchFile Signed-off-by: Danil Uzlov <[email protected]> * format Test_WatchFile Signed-off-by: Danil Uzlov <[email protected]> * use more appropriate test checking functions Signed-off-by: Danil Uzlov <[email protected]> * remove log helper function Signed-off-by: Danil Uzlov <[email protected]> * expect separate create and write events Signed-off-by: Danil Uzlov <[email protected]> * fix linter warning Signed-off-by: Danil Uzlov <[email protected]> * use context with timeout instead of manual timeouts Signed-off-by: Danil Uzlov <[email protected]> * use testing.TempDir instead of system temp dir Signed-off-by: Danil Uzlov <[email protected]> * clean code Signed-off-by: Danil Uzlov <[email protected]> * remove unnecessary stuff around testing.TempDir Signed-off-by: Danil Uzlov <[email protected]> Signed-off-by: NSMBot <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nsmbot
pushed a commit
that referenced
this pull request
Apr 23, 2024
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/7369b5fd24fe89c8021d5dcf3f5aea3393a64805 commit 7369b5fd24fe89c8021d5dcf3f5aea3393a64805 Author: Nikita Skrynnik <[email protected]> Date: Tue Apr 23 20:12:10 2024 +0700 Delete check-release-branch job from release workflow (#130) * Delete check-release-branch job from release workflow Signed-off-by: NikitaSkrynnik <[email protected]> * minor fixes Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
added a commit
that referenced
this pull request
Apr 23, 2024
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/7369b5fd24fe89c8021d5dcf3f5aea3393a64805 commit 7369b5fd24fe89c8021d5dcf3f5aea3393a64805 Author: Nikita Skrynnik <[email protected]> Date: Tue Apr 23 20:12:10 2024 +0700 Delete check-release-branch job from release workflow (#130) * Delete check-release-branch job from release workflow Signed-off-by: NikitaSkrynnik <[email protected]> * minor fixes Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit b09db2d Author: NSMBot [email protected] Date: Tue May 4 09:24:13 2021 +0000 Update go.mod and go.sum to latest version from networkservicemesh/sdk@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit 2f267b7a5b1bcf896a579564e91c6a33ed80c37b Author: Uzlov Danil [email protected] Date: Tue May 4 16:23:47 2021 +0700 Fix Test_WatchFile instability (#886) Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go enable testing for WatchFile Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add checks into watchFile test Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add proper checks for PathError Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go use unique path for every test attempt Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go clean error checking code Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go exclude ubuntu and macos from testing Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go retry mkdir on failure Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go reenable ubuntu and macos testing Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add extra info for macos debuging Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go print each event Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go mitigate macos inconsistency Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go test Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go test Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go add more debug logs Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go clean code Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go remove sleep Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go revert from context timeout to timeout per event Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go enable all tests Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go clean code Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go extract constant for macos-specific behaviour handling Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go refactor Test_WatchFile Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go format Test_WatchFile Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go use more appropriate test checking functions Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go remove log helper function Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go expect separate create and write events Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go fix linter warning Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go use context with timeout instead of manual timeouts Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go use testing.TempDir instead of system temp dir Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go clean code Signed-off-by: Danil Uzlov [email protected] Dockerfile LICENSE README.md go.mod go.sum internal main.go staticcheck.conf suite_healthcheck_test.go suite_setup_test.go suite_test.go suite_util_test.go remove unnecessary stuff around testing.TempDir Signed-off-by: Danil Uzlov [email protected] Signed-off-by: NSMBot [email protected]