Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting of registration url via env variable #139

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Allow setting of registration url via env variable #139

merged 3 commits into from
Aug 28, 2023

Conversation

bellycat77
Copy link
Contributor

Use env variable NSM_REGISTER_AS_URL for NSE registration #119

denis-tingaikin
denis-tingaikin reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added cosmetic comments.

Also note: we should use RegisterAsURL as listenOn if its presented.

Attach docker test for covering the scenario OR logs from k8s running with set env.

main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@bellycat77
Address review comment
28645b1 
Signed-off-by: Ivan Osipov <[email protected]>
@denis-tingaikin denis-tingaikin merged commit 7179e47 into networkservicemesh:main Aug 28, 2023
12 checks passed
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 28, 2023
Update go.mod and go.sum to latest version from networkservicemesh/cm…
70e2e7d 
…d-nse-simple-vl3-docker@main

PR link: networkservicemesh/cmd-nse-simple-vl3-docker#139

Commit: 7179e47
Author: Denis Tingaikin
Date: 2023-08-28 19:40:32 +0300
Message:
  - Merge pull request #139 from bellycat77/add-url-registration-env
Signed-off-by: NSMBot <[email protected]>
@bellycat77 bellycat77 deleted the add-url-registration-env branch September 22, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bellycat77 @denis-tingaikin