Remove duplicated IPAM code #135
Conversation
wazsone
force-pushed
the
feature/remove-duplicated-ipam-code
branch
from
09c07e3
to
042c9c7
Compare
Signed-off-by: Ruslan Bayandinov <[email protected]>
wazsone
force-pushed
the
feature/remove-duplicated-ipam-code
branch
from
042c9c7
to
b4bfb22
Compare
main.go
Outdated
| @@ -157,7 +155,7 @@ func main() { | |||
| log.FromContext(ctx).Infof("executing phase 3: parsing network prefixes for ipam") | |||
| // ******************************************************************************** | |||
|
|
|||
| ipamChain := getIPAMChain(ctx, cfg.CidrPrefix) | |||
| ipamChain := groupipam.NewServer(cfg.CidrPrefix) | |||
There was a problem hiding this comment.
| ipamChain := groupipam.NewServer(cfg.CidrPrefix) |
There was a problem hiding this comment.
Please do it inline at 170
Also note, that here we should use singlepointipam.
Consider to use option groupipam.WithCustomImapServer(singlepointipam.NewServer)
There was a problem hiding this comment.
@denis-tingaikin done
Signed-off-by: Ruslan Bayandinov <[email protected]>
Signed-off-by: Ruslan Bayandinov <[email protected]>
| if len(cfg.CidrPrefix) != 1 { | ||
| logrus.Fatal("Only one CIDR prefix group expected") | ||
| } |
There was a problem hiding this comment.
Why do we need to check it?
There was a problem hiding this comment.
@denis-tingaikin As far as I remember we discussed to add this check because we had agreed on changing CidrPrefix type from []string to cidr.Groups.
|
@zolug Would you have a look at these changes? Don't you mind if we go with this approach? |
Hi! |
|
@zolug Agreed, lets postpone this for cmd-nse-remote-vlan |
Related to networkservicemesh/sdk#1409