Delete grpc.WithBlock() and grpc.WaitForReady(true) options (#917)

* Delete grpc.WithBlock() and grpc.WaitForReady(true) options Signed-off-by: Nikita Skrynnik <[email protected]> * fix linter Signed-off-by: Nikita Skrynnik <[email protected]> --------- Signed-off-by: Nikita Skrynnik <[email protected]>
networkservicemesh · Aug 11, 2023 · 2d3d13c · 2d3d13c
1 parent 5dd4018
commit 2d3d13c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/internal/tests/suite_healthcheck_test.go b/internal/tests/suite_healthcheck_test.go
@@ -1,4 +1,4 @@
-// Copyright (c) 2020-2022 Cisco and/or its affiliates.
+// Copyright (c) 2020-2023 Cisco and/or its affiliates.
 //
 // SPDX-License-Identifier: Apache-2.0
 //
@@ -23,7 +23,6 @@ import (
 
 	"github.com/networkservicemesh/sdk/pkg/tools/log/logruslogger"
 
-	"google.golang.org/grpc"
 	"google.golang.org/grpc/health/grpc_health_v1"
 
 	"github.com/networkservicemesh/sdk/pkg/tools/log"
@@ -38,7 +37,6 @@ func (f *ForwarderTestSuite) TestHealthCheck() {
 		&grpc_health_v1.HealthCheckRequest{
 			Service: "networkservice.NetworkService",
 		},
-		grpc.WaitForReady(true),
 	)
 	f.NoError(err)
 	f.Require().NotNil(healthResponse)

diff --git a/internal/tests/suite_setup_test.go b/internal/tests/suite_setup_test.go
@@ -173,7 +173,6 @@ func (f *ForwarderTestSuite) SetupSuite() {
 	f.sutCC, err = grpc.DialContext(f.ctx,
 		regEndpoint.NetworkServiceEndpoint.GetUrl(),
 		grpc.WithTransportCredentials(clientCreds),
-		grpc.WithBlock(),
 		grpc.WithDefaultCallOptions(
 			grpc.PerRPCCredentials(token.NewPerRPCCredentials(spiffejwt.TokenGeneratorFunc(source, f.config.MaxTokenLifetime))),
 		),

diff --git a/main.go b/main.go
@@ -228,9 +228,7 @@ func main() {
 
 	dialOptions := append(
 		tracing.WithTracingDial(),
-		grpc.WithBlock(),
 		grpc.WithDefaultCallOptions(
-			grpc.WaitForReady(true),
 			grpc.PerRPCCredentials(token.NewPerRPCCredentials(spiffejwt.TokenGeneratorFunc(source, cfg.MaxTokenLifetime)))),
 		grpc.WithTransportCredentials(
 			grpcfd.TransportCredentials(