Prevent double applying annotation when namespace annotation is used #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vyacheslav Tumanov <[email protected]>
Signed-off-by: Vyacheslav Tumanov <[email protected]>
Signed-off-by: Vyacheslav Tumanov <[email protected]>
glazychev-art
approved these changes
Nov 1, 2022
main.go
Outdated
| @@ -86,7 +86,12 @@ func (s *admissionWebhookServer) Review(ctx context.Context, in *admissionv1.Adm | |||
| annotation := podMetaPtr.Annotations[s.config.Annotation] | |||
|
|
|||
| // use namespace annotation only if resource doesn't have it's own | |||
There was a problem hiding this comment.
Minor comment:
We can move this comment below
There was a problem hiding this comment.
I agree, forgot to move when new if statement have been added. Fixed 👍
Signed-off-by: Vyacheslav Tumanov <[email protected]>
denis-tingaikin
approved these changes
Nov 9, 2022
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Nov 9, 2022
…d-admission-webhook-k8s@main PR link: networkservicemesh/cmd-admission-webhook-k8s#198 Commit: 36b6bbe Author: Denis Tingaikin Date: 2022-11-09 12:12:12 +0300 Message: - Merge pull request #198 from ThetaDR/namespace-annotation-fix Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vyacheslav Tumanov [email protected]
Related issue: networkservicemesh/deployments-k8s#7676