feat: add dns service for vl3 networks #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <[email protected]>
denis-tingaikin
commented
May 10, 2022
Comment on lines
+20
to
+41
| package dns; | ||
| option go_package = "github.com/networkservicemesh/api/pkg/api/dns"; | ||
|
|
||
| enum Type { | ||
| UNDEFINED = 0; | ||
| ASSIGN = 1; | ||
| UNASSIGN = 2; | ||
| } | ||
|
|
||
| message DNSRequest { | ||
| Type type = 1; | ||
| map<string, string> labels = 2; | ||
| string ip = 3; | ||
| } | ||
|
|
||
| message DNSResponse { | ||
| string name = 1; | ||
| } | ||
|
|
||
| service DNS { | ||
| rpc ManageNames (stream DNSRequest) returns (stream DNSResponse); | ||
| } |
There was a problem hiding this comment.
@edwarnicke Could you review this?
denis-tingaikin
commented
May 10, 2022
| message DNSRequest { | ||
| Type type = 1; | ||
| map<string, string> labels = 2; | ||
| string ip = 3; |
There was a problem hiding this comment.
Since NSM supports multiple ips, I guess we should change this to
Suggested change
| string ip = 3; | |
| repeated string ip = 3; |
@edwarnicke Thoughts?
edwarnicke
approved these changes
May 11, 2022
nsmbot
pushed a commit
to networkservicemesh/sdk
that referenced
this pull request
May 12, 2022
…i@main PR link: networkservicemesh/api#137 Commit: c57fd26 Author: Denis Tingaikin Date: 2022-05-12 05:05:24 +0300 Message: - add dns service for vl3 networks (#137) Signed-off-by: NSMBot <[email protected]>
denis-tingaikin
added a commit
to denis-tingaikin/api
that referenced
this pull request
May 30, 2022
This reverts commit c57fd26. Signed-off-by: denis-tingaikin <[email protected]>
edwarnicke
pushed a commit
that referenced
this pull request
May 30, 2022
* Revert "qfix: add missed dnsconfigs (#141)" This reverts commit edaa6f4. Signed-off-by: denis-tingaikin <[email protected]> * Revert "add dns service for vl3 networks (#137)" This reverts commit c57fd26. Signed-off-by: denis-tingaikin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingaikin [email protected]
networkservicemesh/cmd-nse-vl3-vpp#45