POC: Use reusable workflow #3
Conversation
Signed-off-by: Albert Safin <[email protected]>
|
@edwarnicke This apporoach is looking promising to me. I guess we can simplify many things with using resusable worflows. Do you mind if we go this apporoach? |
| echo "attempt $attempt" | ||
| git fetch -p origin | ||
| base=$release | ||
| git show-ref --quiet refs/remotes/origin/$base || base=main |
There was a problem hiding this comment.
note: base=main is not expected for release.
There was a problem hiding this comment.
If the $release branch doesn't exist, we start it from the main branch. Or should we use a specific starting commit?
There was a problem hiding this comment.
I think we should stop release if we don't have release branch
There was a problem hiding this comment.
It's a branch in the dependent repository (not in the current one, which is running on the CI). Currently, branches in dependent repositories are created automatically from the main branch.
Details: our current release.yaml uses the actions/checkout action to fetch the dependent repository. According to actions/checkout doc, the default (i.e. main) branch is used. Then our release.yaml creates a release branch, dropping an already existing branch (since the force push -f flag being used).
In short, the current logic of update-dependent-repositories job:
Create a release branch starting from the main branch. Override it if it already exists (hence the conflict described in the issue).
Logic In this PR:
Create a release branch if it doesn't exist. Otherwise, append a commit to an existing release branch.
Issue: networkservicemesh/cmd-template#95
For example usage, see networkservicemesh/sdk-sriov#390.