Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrading doc on fail fast #961

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #960

Missed out this particular change.

This was partially done to distinguish the fail fast result from true exceptions such as when references could not be resolved.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32356e9) 79.01% compared to head (eb382cb) 79.01%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #961   +/-   ##
=========================================
  Coverage     79.01%   79.01%           
  Complexity     1726     1726           
=========================================
  Files           158      158           
  Lines          5753     5753           
  Branches       1087     1087           
=========================================
  Hits           4546     4546           
  Misses          809      809           
  Partials        398      398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 8f47aac into networknt:master Feb 7, 2024
4 checks passed
@justin-tay justin-tay deleted the failfastdocs branch February 20, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FailFast Property Does Not Throw JsonSchemaException for Validation Errors in v1.3.1
3 participants