Fix for required annotations for evaluation not collected #944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #943
The current logic for determining if annotations are needed to be collected for evaluation checks if the keyword exists in the meta schema of where that keyword is. eg. the
properties
validator is checking for theunevaluatedProperties
but theproperties
may be existing in a Draft 7 schema whereunevaluatedProperties
is not a keyword but the outer schema is a Draft 2020-12 schema.The check is now removed and it just checks if a validator with that keyword exists on the evaluation path.