Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for required annotations for evaluation not collected #944

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #943

The current logic for determining if annotations are needed to be collected for evaluation checks if the keyword exists in the meta schema of where that keyword is. eg. the properties validator is checking for the unevaluatedProperties but the properties may be existing in a Draft 7 schema where unevaluatedProperties is not a keyword but the outer schema is a Draft 2020-12 schema.

The check is now removed and it just checks if a validator with that keyword exists on the evaluation path.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (49a44c9) 78.85% compared to head (2f060d9) 78.85%.

Files Patch % Lines
...va/com/networknt/schema/output/OutputUnitData.java 84.61% 1 Missing and 1 partial ⚠️
...va/com/networknt/schema/AbstractJsonValidator.java 0.00% 0 Missing and 1 partial ⚠️
...n/java/com/networknt/schema/BaseJsonValidator.java 90.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #944      +/-   ##
============================================
- Coverage     78.85%   78.85%   -0.01%     
- Complexity     1687     1690       +3     
============================================
  Files           157      157              
  Lines          5652     5661       +9     
  Branches       1068     1068              
============================================
+ Hits           4457     4464       +7     
- Misses          794      798       +4     
+ Partials        401      399       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 2795d79 into networknt:master Feb 1, 2024
4 checks passed
@justin-tay justin-tay deleted the gh943 branch February 20, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since 1.3.1: unevaluatedProperties doesn't work with external schemas
3 participants