Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize logging by creating a debug flag #1054

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

justin-tay
Copy link
Contributor

This creates a debugEnabled flag in ExecutionConfig that is checked to determine if the debug logs should be generated. This is a performance optimization as it was noticed during profiling that since this debug function runs very frequently during validation execution the time taken just to determine if the logger is enabled is significant.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 79.68750% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (48ca3c2) to head (da43eb8).
Report is 23 commits behind head on master.

Files Patch % Lines
...n/java/com/networknt/schema/BaseJsonValidator.java 0.00% 9 Missing and 1 partial ⚠️
...ain/java/com/networknt/schema/ExecutionConfig.java 50.00% 2 Missing ⚠️
...java/com/networknt/schema/DynamicRefValidator.java 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1054      +/-   ##
============================================
- Coverage     78.90%   78.66%   -0.24%     
- Complexity     1965     2018      +53     
============================================
  Files           172      190      +18     
  Lines          6352     6526     +174     
  Branches       1255     1244      -11     
============================================
+ Hits           5012     5134     +122     
- Misses          867      921      +54     
+ Partials        473      471       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 028710e into networknt:master Jun 11, 2024
4 checks passed
@justin-tay justin-tay deleted the debug branch June 12, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants