Detect invalid escape for ecmascript #1049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the test failure from the JSON Schema Test Suite in
optional/ecmascript-regex.json
asjoni
does not detect invalid escapes.This makes the following changes
regex
format has been changed to also follow the configuration of whether to useecma-262
compliant regex. Previously it always used thejdk
regex.JoniRegularExpression
implementation uses a regex to detect if an invalid escape is used asjoni
doesn't detect invalid escapes. In actuality it's upstreamOniguruma
doesn't actually support ecma as a syntax.optional/ecmascript-regex.json
has been updated. In actuality it doesn't change anything but it is clearer that"format": "regex"
is used in the testoptional/ecmascript-regex.json
test