Skip to content

fix memory leak of %rep mmacro #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix memory leak of %rep mmacro #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions asm/preproc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7594,6 +7594,7 @@ static Token *pp_tokline(void)
break;
} else {
MMacro *m = istk->mstk.mstk;
bool should_free_mmacro = false;

/*
* Check whether a `%rep' was started and not ended
Expand Down Expand Up @@ -7648,6 +7649,8 @@ static Token *pp_tokline(void)
m->paramlen = NULL;
}
}
else
should_free_mmacro = true;

if (fm->nolist & NL_LINE) {
istk->noline--;
Expand All @@ -7667,16 +7670,8 @@ static Token *pp_tokline(void)

istk->where = l->where;

/*
* FIXME It is incorrect to always free_mmacro here.
* It leads to usage-after-free.
*
* https://bugzilla.nasm.us/show_bug.cgi?id=3392414
*/
#if 0
else
if (should_free_mmacro)
free_mmacro(m);
#endif
}
istk->expansion = l->next;
nasm_free(l);
Expand Down