error 500: Ensure text is legible with foreground colors #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`all: initial` restores the color and background from the user agent style sheet. If user changes those, the text will become illegible.
jtojnar
commented
Jul 10, 2024
| @@ -21,8 +21,8 @@ namespace Tracy; | |||
| <style> | |||
| #tracy-error { all: initial; position: absolute; top: 0; left: 0; right: 0; height: 70vh; min-height: 400px; display: flex; align-items: center; justify-content: center; z-index: 1000 } | |||
| #tracy-error div { all: initial; max-width: 550px; background: white; color: #333; display: block } | |||
| #tracy-error h1 { all: initial; font: bold 50px/1.1 sans-serif; display: block; margin: 40px } | |||
| #tracy-error p { all: initial; font: 20px/1.4 sans-serif; margin: 40px; display: block } | |||
| #tracy-error h1 { all: initial; background: white; color: #333; font: bold 50px/1.1 sans-serif; display: block; margin: 40px } | |||
There was a problem hiding this comment.
The initial background will probably be transparent so the background reset might not be necessary but who knows.
dg
force-pushed
the
master
branch
4 times, most recently
from
b39998b
to
5906211
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
e89fde9
to
5718904
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
8497673
to
37495a7
Compare
dg
added a commit
to nette/application
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all: initialrestores the color and background from the user agent style sheet. If user changes those, the text will become illegible.Here is how to change the text color in firefox: https://support.mozilla.org/cs/kb/zmena-pisma-barev-na-webovych-strankach#w_zmena-barvy-pisma
Here is how it looks like in my tweaked UI without this patch: