Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dumper: do not quote dumped keys #340

Closed
wants to merge 2 commits into from
Closed

Dumper: do not quote dumped keys #340

wants to merge 2 commits into from

Conversation

milo
Copy link
Member

@milo milo commented Feb 15, 2019

Is there any reason for quoting dumped array keys/object property names? For example:

array (2)
    Accept => "application/json" (16)
    "User-Agent" => "milo/http-client-v5.2" (21)

Empty string is preserver quoted.

@dg
Copy link
Member

dg commented Feb 15, 2019

It should preserve quotes in keys like "hello " too.

@milo
Copy link
Member Author

milo commented Feb 15, 2019

Something like this?

@dg dg closed this in ec1ba86 Feb 15, 2019
@dg
Copy link
Member

dg commented Feb 15, 2019

I made it a little easier.

dg pushed a commit that referenced this pull request Feb 15, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
a4c9b1c
dg pushed a commit that referenced this pull request Feb 15, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
9bb95ec
@milo
Copy link
Member Author

milo commented Feb 15, 2019

Great. Thank you!

dg pushed a commit that referenced this pull request Feb 15, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
e11691c
dg pushed a commit that referenced this pull request Feb 16, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
4b56534
dg pushed a commit that referenced this pull request Feb 17, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
047a392
dg pushed a commit that referenced this pull request Feb 17, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
43dfafd
dg pushed a commit that referenced this pull request Feb 17, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
549a131
dg pushed a commit that referenced this pull request Feb 17, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
ec2d456
dg pushed a commit that referenced this pull request Feb 17, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
212ac2c
dg pushed a commit that referenced this pull request Feb 17, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
4cdce85
dg pushed a commit that referenced this pull request Feb 17, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
d84d98f
dg pushed a commit that referenced this pull request Feb 20, 2019
@dg
Dumper: do not quote dumped keys [Closes #340]
b21853c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milo @dg