-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize Codebase #18
Draft
TheMrSheldon
wants to merge
35
commits into
netspeak:master
Choose a base branch
from
TheMrSheldon:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…; compacted nested namespace definitions
…cated std::bind2nd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The age of the codebase is quite apparent in some places (e.g.
boost::filesystem
instead ofstd::filesystem
and similar foroptional
and others). This pull-request aims to improve on this by modernizing the CMake build files, integrating protobuffs and antrl into the CMake build process instead of providing separate scripts, and updating the code to use C++23 features.limits
instead ofUINT32_MAX
and coNULL
withnullptr
boost::filesystem
withstd::filesystem
boost::filesystem::ofstream
was deprecated and removed and should be replacedboost::optional
withstd::optional
boost::regex
withstd::regex
(may not work due to minor implementation differences)boost::posix_time
withstd::chrono
std::unary_function
std::binary_function
std::bind2nd
withstd::bind
<codecvt>
throw
declarations and replacethrow()
withnoexcept
std::tuple
util::Mut
since its semantics are unclear Mut::Lock can be replaced withstd::shared_ptr<std::lock_guard>
and aliasingFileDescriptor.hpp
usingstd::filesystem
boost::program_options
withCLI11
(more readable API; supports configuration files and environment variables; supports subcommands)JsonWriter
be replaced withnlohmann/json
(or rapid json if efficiency is desired)?is_valid_utf8
withis_valid
fromutf8cpp
and similar fornumber_of_utf8_bytes
Boost.Test
to more modern systems likeCatch2
orgoogletest
Some of these points require more elaborate unit testing and separate pull requests and issues to recognize the work necessary and ensure compatibility. These are marked with an *.