-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webapp development notes #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @mwfarb)
webapp/development.md, line 52 at r2 (raw file):
## Future Features * **Latency Tests**: *(in development)* SCION ping and traceroute results would be listed next to available paths or overlaid on path graphs allowing easy examination of performance. * **Name Resolution**: Integration with the SCION name resolution service (RAINS), would optionally show full AS names rather than IA numbers.
Nitpick: RAINS resolves host names, not AS names.
webapp/development.md, line 95 at r2 (raw file):
git clone -b scionlab https://github.com/netsec-ethz/scion-apps cd scion-apps mkdir ~/go/bin # needed for make bug
I don't think this is needed anymore; install
does mkdir -p $(DESTDIR)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mwfarb!
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mwfarb)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is