Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new FLP API to build pipeline #110

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

jotak
Copy link
Member

@jotak jotak commented May 31, 2022

draft, requires not-merged netobserv/flowlogs-pipeline#213

@openshift-ci
Copy link

openshift-ci bot commented May 31, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner now. Thanks!

@openshift-ci openshift-ci bot removed the lgtm label Jun 2, 2022
@jotak jotak marked this pull request as ready for review June 2, 2022 07:06
@jotak
Copy link
Member Author

jotak commented Jun 2, 2022

Ready for review, now pointing to the actual FLP version (Mario already reviewed but needs lgtm again)
This PR is necessary to fix kafka pipeline (due to a breaking change in netobserv/flowlogs-pipeline#213 )

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jotak
Copy link
Member Author

jotak commented Jun 2, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 748460a into netobserv:main Jun 2, 2022
@jotak jotak deleted the use-pipeline-api branch December 7, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants