[NETOBSERV-2376] FlowCollector Status Page UI Test #1439
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| kind: FlowCollector | ||
| apiVersion: flows.netobserv.io/v1beta2 | ||
| metadata: | ||
| name: cluster | ||
| spec: | ||
| agent: | ||
| ebpf: | ||
| sampling: 1 | ||
| type: eBPF | ||
| loki: | ||
| enable: true | ||
| mode: LokiStack | ||
| lokiStack: | ||
| name: loki |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,62 @@ | ||||||||||||||
| import { Operator } from "@views/netobserv" | ||||||||||||||
| import { flowcollectorStatusPage, flowcollectorStatusSelectors } from "@views/flowcollector-status" | ||||||||||||||
|
|
||||||||||||||
| describe('Network_Observability FlowCollector status error scenario', { tags: ['Network_Observability'] }, function () { | ||||||||||||||
|
|
||||||||||||||
| before('setup', function () { | ||||||||||||||
| cy.adminCLI(`oc adm policy add-cluster-role-to-user cluster-admin ${Cypress.env('LOGIN_USERNAME')}`) | ||||||||||||||
| cy.uiLogin(Cypress.env('LOGIN_IDP'), Cypress.env('LOGIN_USERNAME'), Cypress.env('LOGIN_PASSWORD')) | ||||||||||||||
|
|
||||||||||||||
| Operator.install() | ||||||||||||||
| cy.checkStorageClass(this) | ||||||||||||||
|
|
||||||||||||||
| Operator.createFlowcollector("LokiWithoutLokiStack") | ||||||||||||||
| }) | ||||||||||||||
|
|
||||||||||||||
| it("(OCP-88744, kapjain, Network_Observability) Verify error status when Loki enabled without LokiStack", function () { | ||||||||||||||
| // Visit status page and wait for Ready condition to show False (error state) | ||||||||||||||
| flowcollectorStatusPage.visit() | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.readyRow, { timeout: 120000 }).should('exist') | ||||||||||||||
| .should('have.attr', 'data-test-status', 'False') | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.readyRow) | ||||||||||||||
| .should('have.attr', 'data-test-reason') | ||||||||||||||
| .and('not.equal', 'Pending') | ||||||||||||||
| .and('not.equal', 'Valid') | ||||||||||||||
|
|
||||||||||||||
| // Verify WaitingFLPMonolith condition shows error about loki-gateway-ca-bundle | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.flpMonolithRow).should('exist') | ||||||||||||||
| .should('have.attr', 'data-test-status', 'True') | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.flpMonolithRow).parent() | ||||||||||||||
| .should('contain.text', 'loki-gateway-ca-bundle') | ||||||||||||||
|
|
||||||||||||||
| // Verify Flowlogs Pipeline component shows error about loki-gateway-ca-bundle | ||||||||||||||
| cy.contains('td', 'Flowlogs Pipeline').parent('tr') | ||||||||||||||
| .should('contain.text', 'loki-gateway-ca-bundle') | ||||||||||||||
|
Comment on lines
+33
to
+34
Contributor
There was a problem hiding this comment. Fragile row lookup — anchor to the component table.
♻️ Suggested tightening- cy.contains('td', 'Flowlogs Pipeline').parent('tr')
- .should('contain.text', 'loki-gateway-ca-bundle')
+ cy.contains('Component statuses')
+ .parents('section, [role="region"], .pf-v6-c-card, .pf-c-card').first()
+ .contains('td', /^Flowlogs Pipeline$/).parent('tr')
+ .should('contain.text', 'loki-gateway-ca-bundle')As per coding guidelines, 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| // Verify WaitingLokiStack condition shows LokiStack not found error | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.lokiStackRow).should('exist') | ||||||||||||||
| .should('have.attr', 'data-test-status', 'True') | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.lokiStackRow) | ||||||||||||||
| .should('contain.text', 'Loki is configured in LokiStack mode, but LokiStack API is missing') | ||||||||||||||
|
Comment on lines
+36
to
+40
Contributor
There was a problem hiding this comment. Do not assert the environment-specific LokiStack API message. This exact text only holds when the LokiStack API is absent. On clusters where the CRD exists but the Proposed adjustment // Verify WaitingLokiStack condition shows LokiStack not found error
cy.get(flowcollectorStatusSelectors.lokiStackRow).should('exist')
.should('have.attr', 'data-test-status', 'True')
+ .should('have.attr', 'data-test-reason', 'CantFetchLokiStack')
cy.get(flowcollectorStatusSelectors.lokiStackRow)
- .should('contain.text', 'Loki is configured in LokiStack mode, but LokiStack API is missing')
+ .should('contain.text', 'LokiStack')As per coding guidelines, 🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| // Verify WaitingFLPParent condition shows FLP error | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.flpParentRow).should('exist') | ||||||||||||||
| .should('have.attr', 'data-test-status', 'True') | ||||||||||||||
| .and('have.attr', 'data-test-reason', 'FLPError') | ||||||||||||||
|
|
||||||||||||||
| // Verify status icon tooltip shows error | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.statusButton) | ||||||||||||||
| .find('span span').trigger('mouseenter', { force: true }) | ||||||||||||||
| cy.get(flowcollectorStatusSelectors.statusTooltip, { timeout: 10000 }) | ||||||||||||||
| .should('contain.text', 'FlowCollector has errors') | ||||||||||||||
|
|
||||||||||||||
| // Verify "Open Network Traffic page" button is disabled | ||||||||||||||
| cy.byLegacyTestID('open-network-traffic').should('exist') | ||||||||||||||
| .should('have.attr', 'aria-disabled', 'true') | ||||||||||||||
| }) | ||||||||||||||
|
|
||||||||||||||
| after("all tests", function () { | ||||||||||||||
| Operator.deleteFlowCollector() | ||||||||||||||
| cy.adminCLI(`oc adm policy remove-cluster-role-from-user cluster-admin ${Cypress.env('LOGIN_USERNAME')}`) | ||||||||||||||
| }) | ||||||||||||||
| }) | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| export namespace flowcollectorStatusSelectors { | ||
|
Member
There was a problem hiding this comment. these can be moved to netfow-page.ts instead of a new file
Member
Author
There was a problem hiding this comment. I think if Page is diff it should have a diff view |
||
| export const statusIndicator = '#flowcollector-status-indicator' | ||
| export const statusButton = 'button[aria-label="FlowCollector status"]' | ||
| export const statusTooltip = '#flowcollector-status-tooltip' | ||
| export const readyRow = '[id=Ready-row]' | ||
| export const agentReadyRow = '[id=WaitingEBPFAgents-row]' | ||
| export const pluginReadyRow = '[id=WaitingWebConsole-row]' | ||
| export const monitoringReadyRow = '[id=WaitingMonitoring-row]' | ||
| export const configIssueRow = '[id=ConfigurationIssue-row]' | ||
| export const flpMonolithRow = '[id=WaitingFLPMonolith-row]' | ||
| export const lokiStackRow = '[id=WaitingLokiStack-row]' | ||
| export const flpParentRow = '[id=WaitingFLPParent-row]' | ||
| } | ||
|
|
||
| export const flowcollectorStatusPage = { | ||
| visit: () => { | ||
| cy.visit('k8s/cluster/flows.netobserv.io~v1beta2~FlowCollector/status') | ||
| cy.get(flowcollectorStatusSelectors.readyRow, { timeout: 30000 }).should('exist') | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,27 @@ | ||||||||||||||||||||||||||
| export const searchPage = { | ||||||||||||||||||||||||||
| navToSearchPage: () => cy.visit('/search/all-namespaces'), | ||||||||||||||||||||||||||
| chooseResourceType: (resource_type) => { | ||||||||||||||||||||||||||
| cy.get('input[placeholder="Resources"]').clear().type(`${resource_type}`); | ||||||||||||||||||||||||||
| cy.get(`label[id$="~${resource_type}"]`).click(); | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
| checkNoMachineResources: () => { | ||||||||||||||||||||||||||
| searchPage.navToSearchPage(); | ||||||||||||||||||||||||||
| cy.get('[placeholder="Resources"]').type("machine"); | ||||||||||||||||||||||||||
| const machineResources = ['MMachine','MAMachineAutoscaler','MCMachineConfig','MCPMachineConfigPool','MHCMachineHealthCheck','MSMachineSet']; | ||||||||||||||||||||||||||
| machineResources.forEach((machineResource) => { | ||||||||||||||||||||||||||
| cy.get(`[data-filter-text=${machineResource}]`).should('not.exist'); | ||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
| clearAllFilters: () => { | ||||||||||||||||||||||||||
|
Member
Author
There was a problem hiding this comment. I just copied the search view from openshfit-test-private repo and this function is for search view. |
||||||||||||||||||||||||||
| cy.byButtonText('Clear all filters').click({force: true}); | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
| searchMethodValues: (method, value) => { | ||||||||||||||||||||||||||
| method = method.toLocaleLowerCase(); | ||||||||||||||||||||||||||
| cy.get('button[id="search-filter-toggle"]').click(); | ||||||||||||||||||||||||||
| cy.get(`li[data-test="${method}-filter"] button[role="option"]`).click(); | ||||||||||||||||||||||||||
| cy.get('input[id="search-filter-input"]').clear().type(`${value}`); | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
|
Comment on lines
+18
to
+23
Contributor
There was a problem hiding this comment. Prefer
- method = method.toLocaleLowerCase();
+ method = method.toLowerCase();📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
| searchBy: (text) => { | ||||||||||||||||||||||||||
| cy.get('input[data-test-id="item-filter"]').clear().type(`${text}`) | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error-scenario
beforehook skips the "FlowCollector already exists" guard.Unlike the success scenario which uses
Operator.createFlowcollector()(which deletes any pre-existing FC and waits for console refresh), this blockoc applys directly. If the previousdescribe'safterfailed for any reason (see the outstanding concern aboutafterhooks not running whenbeforethrows), the old Ready FlowCollector will be patched in-place rather than replaced, and the 120s wait at Line 127 may observe staleReady=Truestatus before flipping. Suggest callingOperator.deleteFlowCollector()first, or reusingOperator.createFlowcollector('LokiWithoutStack')(after fixing the Ready assertion flagged innetobserv.ts), plus a console-refresh wait similar tocreateFlowcollector.🤖 Prompt for AI Agents