Skip to content

Fix console proxy declaration#37

Closed
jotak wants to merge 2 commits intonetobserv:mainfrom
jotak:fix-console-proxy-declaration
Closed

Fix console proxy declaration#37
jotak wants to merge 2 commits intonetobserv:mainfrom
jotak:fix-console-proxy-declaration

Conversation

@jotak
Copy link
Copy Markdown
Member

@jotak jotak commented Dec 14, 2021

This is fixing the console proxy declaration, so that it can work in "production mode" (ie. console not deployed on host with bridge).

Requires a fix in openshift-api (PR coming soon)

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jotak after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Copy Markdown
Member Author

jotak commented Dec 14, 2021

(first commit in vendors update, second commit is code change)

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 14, 2021

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci 544da95 link true /test ci

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak
Copy link
Copy Markdown
Member Author

jotak commented Dec 14, 2021

related fix in openshift-api: openshift/api#1085

@jotak
Copy link
Copy Markdown
Member Author

jotak commented Dec 14, 2021

/hold

Do not merge this one, merge this instead: #38
We keep that one opened just for reference (it's referenced in BZ to illustrate the bug: https://bugzilla.redhat.com/show_bug.cgi?id=2032289)
My other PR includes an override of the API vendored

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 15, 2021

@jotak: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak jotak closed this Dec 15, 2021
@jotak jotak deleted the fix-console-proxy-declaration branch April 1, 2022 07:07
KalmanMeth added a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant