Skip to content

NETOBSERV-2182 & NETOBSERV-2183 PoC : Filters refactoring#1632

Merged
jpinsonneau merged 3 commits intomainfrom
2183
Dec 18, 2025
Merged

NETOBSERV-2182 & NETOBSERV-2183 PoC : Filters refactoring#1632
jpinsonneau merged 3 commits intomainfrom
2183

Conversation

@jpinsonneau
Copy link
Copy Markdown
Member

@jpinsonneau jpinsonneau commented Jun 12, 2025

Description

Update columns configs for netobserv/netobserv-web-console#877

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jpinsonneau jpinsonneau mentioned this pull request Jun 12, 2025
Merged
10 tasks
@red-hat-konflux
Copy link
Copy Markdown
Contributor

red-hat-konflux Bot commented Jun 21, 2025

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
network-observability-operator-bundle-ystream-on-push json: cannot unmarshal bool into Go struct field ObjectMeta.metadata.annotations of type string
network-observability-operator-ystream-on-push json: cannot unmarshal bool into Go struct field ObjectMeta.metadata.annotations of type string

@jpinsonneau jpinsonneau marked this pull request as ready for review July 15, 2025 08:59
@jpinsonneau
Copy link
Copy Markdown
Member Author

jpinsonneau commented Jul 15, 2025

Rebased without changes

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 15, 2025

New images:

  • quay.io/netobserv/network-observability-operator:e8f838b
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-e8f838b
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-e8f838b

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:e8f838b make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-e8f838b

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-e8f838b
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

jotak
jotak reviewed Jul 16, 2025
View reviewed changes
Comment thread internal/controller/consoleplugin/config/static-frontend-config.yaml Outdated
name: Namespace
component: autocomplete
autoCompleteAddsQuotes: true
category: targeteable
Copy link
Copy Markdown
Member

@jotak jotak Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly does it mean to be targeteable in this context?
Also, searching the web, it seems we should remove the "e": "targetable".

Copy link
Copy Markdown
Member

@jotak jotak Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I get what it means, it's a "common" field that can also be specialized into "src/dst" variants, right ?

Copy link
Copy Markdown
Member

@jotak jotak Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking out loud - not for this PRs, but I think we could eventually get rid of all the Src/Dst variants in this config file, keep just the targetable, and "expand" it after loading from the console side ? That would shrink this file size and also avoid some repeated content.

Copy link
Copy Markdown
Member Author

@jpinsonneau jpinsonneau Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I get what it means, it's a "common" field that can also be specialized into "src/dst" variants, right ?

yeah it can be source, dest, or both

Copy link
Copy Markdown
Member

@jotak jotak Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to not forget my earlier comment: can you remove the "e"? :-)

Copy link
Copy Markdown
Member

@jotak jotak Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually perhaps rename category as "endpoint" so it matches the terminology that we agreed on in the UI

@jpinsonneau jpinsonneau added the needs-review Tells that the PR needs a review label Aug 27, 2025
@jotak jotak added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. labels Sep 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 16, 2025

New images:

  • quay.io/netobserv/network-observability-operator:1aa9b67
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-1aa9b67
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-1aa9b67

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:1aa9b67 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-1aa9b67

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-1aa9b67
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd Amoghrd removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 6, 2025
@Amoghrd
Copy link
Copy Markdown
Member

Amoghrd commented Nov 6, 2025

/ok-to-test

@openshift-ci openshift-ci Bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 6, 2025

New images:

  • quay.io/netobserv/network-observability-operator:90bf715
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-90bf715
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-90bf715

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:90bf715 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-90bf715

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-90bf715
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@jpinsonneau jpinsonneau added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. labels Nov 20, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 20, 2025

New images:

  • quay.io/netobserv/network-observability-operator:5d39187
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-5d39187
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-5d39187

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:5d39187 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-5d39187

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-5d39187
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@jpinsonneau jpinsonneau added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. labels Dec 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

New images:

  • quay.io/netobserv/network-observability-operator:45d5854
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-45d5854
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-45d5854

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:45d5854 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-45d5854

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-45d5854
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@github-actions github-actions Bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 11, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau added needs-rebase ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. labels Dec 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 11, 2025

New images:

  • quay.io/netobserv/network-observability-operator:d55ea61
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d55ea61
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d55ea61

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:d55ea61 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d55ea61

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d55ea61
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@github-actions github-actions Bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 16, 2025
jotak
jotak approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jpinsonneau LGTM

@openshift-ci openshift-ci Bot added the lgtm label Dec 17, 2025
@Amoghrd
Copy link
Copy Markdown
Member

Amoghrd commented Dec 17, 2025

/ok-to-test

@openshift-ci openshift-ci Bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 17, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2025

New images:

  • quay.io/netobserv/network-observability-operator:99e39d8
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-99e39d8
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-99e39d8

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:99e39d8 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-99e39d8

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-99e39d8
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 17, 2025

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator fb7e542 link false /test e2e-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau jpinsonneau merged commit 64ea017 into main Dec 18, 2025
11 of 13 checks passed
@Amoghrd
Copy link
Copy Markdown
Member

Amoghrd commented Dec 18, 2025

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved QE has approved this pull request label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jotak jotak jotak approved these changes

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

@stleerh stleerh Awaiting requested review from stleerh

Assignees

@jotak jotak

Labels

lgtm needs-review Tells that the PR needs a review ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpinsonneau @Amoghrd @jotak @openshift-merge-robot