Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing konflux error and fixing multi arch build with podman 5.2 #719

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

OlivierCazade
Copy link
Contributor

@OlivierCazade OlivierCazade commented Sep 17, 2024

Description

Fixing multiarch build.
Addressing multiple konflux error:

  • the build not being hermetic
  • removing deprecated task in the build
  • using base image from registry.redhat.io

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.38%. Comparing base (118800c) to head (955d60e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   65.38%   65.38%           
=======================================
  Files         108      108           
  Lines        6960     6960           
=======================================
  Hits         4551     4551           
  Misses       2099     2099           
  Partials      310      310           
Flag Coverage Δ
unittests 65.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@OlivierCazade
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eeef1d6 into netobserv:main Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants