NETOBSERV-934: Add icmpv4/v6 bits to FLP

[msherif1234]

netobserv/netobserv-ebpf-agent#103 added support to ICMPv4/6 and updated gRPC protobuf this PR to syncup flb repo with those changes and update the unit-test cases.

Also gRPC connect api was changed recently to fix ipv6 socket so fixed its use in pipeline_test

[codecov]

Codecov Report

Merging #408 (800cb81) into main (0269dcc) will increase coverage by 0.15%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   63.63%   63.79%   +0.15%     
==========================================
  Files          92       92              
  Lines        6471     6479       +8     
==========================================
+ Hits         4118     4133      +15     
+ Misses       2113     2106       -7     
  Partials      240      240              

Flag	Coverage Δ
unittests	63.79% <92.30%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/utils/convert.go	79.05% <90.90%> (+4.46%)	⬆️
pkg/pipeline/decode/decode_protobuf.go	78.43% <100.00%> (+0.88%)	⬆️

[msherif1234]

/ok-to-test

[github-actions]

New image: quay.io/netobserv/flowlogs-pipeline:8c0432f. It will expire after two weeks.

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-934 which is a valid jira issue.

In response to this:

netobserv/netobserv-ebpf-agent#103 added support to ICMPv4/6 and updated gRPC protobuf this PR to syncup flb repo with those changes and update the unit-test cases.

Also gRPC connect api was changed recently to fix ipv6 socket so fixed its use in pipeline_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[msherif1234]

/ok-to-test

[jotak]

/hold
need to coordinate with QE/doc
cc @memodi @skrthomas

[msherif1234]

/hold cancel
we have released 1.2 so this can go in

[jpinsonneau]

LGTM, thanks @msherif1234 👍

[ronensc]

LGTM

[jotak]

/approve

[jotak]

sorry - removing approval: this will be pre-merge tested, unless QE agrees for post-merge. cc @memodi (this is not for 1.2)

[memodi]

sorry - removing approval: this will be pre-merge tested, unless QE agrees for post-merge. cc @memodi (this is not for 1.2)

ack, we should prioritize this after finishing 1.2 tasks. cc @Amoghrd

[Amoghrd]

/ok-to-test

[msherif1234]

/ok-to-test

[Amoghrd]

/ok-to-test

[github-actions]

New image: quay.io/netobserv/flowlogs-pipeline:1420fee. It will expire after two weeks.

[Amoghrd]

/label qe-approved

[jpinsonneau]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak, jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak,jpinsonneau]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment