This repository was archived by the owner on May 22, 2024. It is now read-only.
chore: add test for node: prefix#698
Merged
eduardoboucas merged 7 commits intomainfrom Nov 8, 2021
Merged
Conversation
Contributor
⏱ Benchmark resultslargeDepsEsbuild: 11.1sLegend
largeDepsZisi: 1m 0.7sLegend
|
Closed
eduardoboucas
changed the title
node: prefixnode: prefix
consumers of this package should use ^8.2!
eduardoboucas
force-pushed
the
fix/node-force-builtin
branch
from
a6d3da9 to
dbf7fd5
Compare
netlify-team-account-1
approved these changes
Nov 8, 2021
Contributor
netlify-team-account-1
left a comment
netlify-team-account-1
left a comment
There was a problem hiding this comment.
Taking back my approval here - are we sure that we don't need to change package.json? If this package is installed by netlify/build, it won't take the package-lock into account, and potentially install precinct@8.0 or precinct@8.1.
netlify-team-account-1
added a commit
that referenced
this pull request
Nov 8, 2021
netlify-team-account-1
added a commit
that referenced
this pull request
Nov 8, 2021
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
* chore: add failing test * chore: update package.json precinct to 8.2, too consumers of this package should use ^8.2! * chore: update test to reflect stream/web problems * chore: adapt fixture to streams * Update main.js * Update main.js * chore: revert change to `package.json` Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com> Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com>
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test asserting that we can handle imports with the
node:prefix.