Skip to content

fix: instrument content-length in blobs .get and .getWithMetadata methods #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix: instrument content-length in blobs .get and .getWithMetadata methods #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/blobs/src/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ export class Store {
})

span?.setAttributes({
'blobs.response.body.size': res.headers.get('content-length') ?? undefined,
Copy link
Contributor Author

@pieh pieh Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attribute name inspired by https://opentelemetry.io/docs/specs/semconv/registry/attributes/http/#http-response-body-size

http.response.body.size
The size of the response payload body in bytes. This is the number of bytes transferred excluding headers and is often, but not always, present as the Content-Length header. For requests using transport encoding, this should be the compressed size.

'blobs.response.status': res.status,
})

Expand Down Expand Up @@ -328,6 +329,7 @@ export class Store {
const responseETag = res?.headers.get('etag') ?? undefined

span?.setAttributes({
'blobs.response.body.size': res.headers.get('content-length') ?? undefined,
'blobs.response.etag': responseETag,
'blobs.response.status': res.status,
})
Expand Down