Add missing doc for Account Members Endpoints #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
erikw
force-pushed
the
erikw/395/add-accounts-update-doc
branch
6 times, most recently
from
ad60a39 to
0e7ef51
Compare
erikw
force-pushed
the
erikw/395/add-accounts-update-doc
branch
2 times, most recently
from
95ff5d3 to
97c182f
Compare
Add documentation for:
* `GET /{account_slug}/members/{member_id}`
* `PUT /{account_slug}/members/{member_id}`
* `DELETE /{account_slug}/members/{member_id}`
Update documentation for:
* `POST /{account_slug}/members` - params should be in request body, not query params.
* I needed to `$ go get -u golang.org/x/sys` as `$ make generate` on
macOS 12.6 with Go 1.19.3 (Homebrew) othwerwise failed with
"go:linkname must refer to declared function or variable".
The suggested solution to update sys comes from
https://stackoverflow.com/a/71508032/265508
Fixes #395
Co-authored-by: Nicola Aitken <[email protected]>
erikw
force-pushed
the
erikw/395/add-accounts-update-doc
branch
from
97c182f to
b3f5a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for:
GET /{account_slug}/members/{member_id}PUT /{account_slug}/members/{member_id}DELETE /{account_slug}/members/{member_id}Update documentation for:
POST /{account_slug}/members- params should be in request body, not query params.I needed to
$ go get -u golang.org/x/sysas$ make generateonmacOS 12.6 with Go 1.19.3 (Homebrew) othwerwise failed with
"go:linkname must refer to declared function or variable".
The suggested solution to update sys comes from
https://stackoverflow.com/a/71508032/265508
go:linkname must refer to declared function or variable golang/go#51706 (comment)
The deploy preview is here:
https://deploy-preview-408--open-api.netlify.app/#tag/member