Skip to content

fix: providing cwd matching the root dir and filter option conflicted… #7366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix: providing cwd matching the root dir and filter option conflicted… #7366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/commands/base-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,9 +500,21 @@ export default class BaseCommand extends Command {
private async init(actionCommand: BaseCommand) {
debug(`${actionCommand.name()}:init`)('start')
const flags = actionCommand.opts()

// here we actually want to use the process.cwd as we are setting the workingDir
// eslint-disable-next-line no-restricted-properties
this.workingDir = flags.cwd ? resolve(flags.cwd) : process.cwd()
const processCwd = process.cwd()

if (flags.cwd) {
const resolvedCwd = resolve(flags.cwd)
this.workingDir = resolvedCwd

// if cwd matches process.cwd, act like cwd wasn't provided
if (resolvedCwd === processCwd) {
delete flags.cwd
Copy link
Contributor

@cmparsons cmparsons Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the main change? I'm kinda confused on what behavior has changed because it seems like we're still resolving to the cwd from the flag or process.cwd()

Copy link
Contributor Author

@VitaliyR VitaliyR Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down the process it is being check

cli/src/commands/base-command.ts

Line 544 in 28252a8

!flags.cwd &&

this.workingDir = processCwd
}
}

// ==================================================
// Create a Project and run the Heuristics to detect
Expand Down
Loading