Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: typecheck tests #7095

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

refactor: typecheck tests #7095

wants to merge 7 commits into from

Conversation

ndhoule
Copy link
Contributor

@ndhoule ndhoule commented Mar 7, 2025

This changeset enables typechecking on test files. It:

  • Separates the TypeScript configuration into two configurations:
    • tsconfig.json: Non-artifact-emitting configuration for development-time typechecking
    • tsconfig.build.json: Artifact-emitting configuration used to build the project
  • Updates tsconfig.json to run the type checker on test files
  • Adds a typechecking CI job
  • Fixes type errors in test files

Copy link

github-actions bot commented Mar 7, 2025

📊 Benchmark results

Comparing with 0e74b4d

  • Dependency count: 1,182 (no change)
  • Package size: 281 MB (no change)
  • Number of ts-expect-error directives: 727 ⬆️ 0.41% increase vs. 0e74b4d

@ndhoule ndhoule force-pushed the build/typecheck-more-files branch from 0e14e16 to 11faf9d Compare March 7, 2025 22:50
ndhoule added 5 commits March 7, 2025 14:51
This change separates the TypeScript configuration into two configurations:

- `tsconfig.json`: Non-artifact-emitting configuration for development-
  time typechecking
- `tsconfig.build.json`: Artifact-emitting configuration used to build
  the project

This includes no functional changes and is simply setup for future
typechecking improvements.
@ndhoule ndhoule force-pushed the build/typecheck-more-files branch 4 times, most recently from b730f17 to 6618c34 Compare March 7, 2025 23:27
@ndhoule ndhoule force-pushed the build/typecheck-more-files branch from 6618c34 to d873e25 Compare March 7, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant