fix(deps): upgrade 23 outdated dependencies #7019

serhalp · 2025-01-31T23:48:31Z

Summary

(Pulling the commander upgrade out of #7008 as it's turning into a can of worms.)

I carefully reviewed all the release notes for all of these. Many of the major bumps are just dropping support for older versions of node.js we already don't support. For anything relatively easy, I made the necessary changes. I punted on the more involved upgrades.

github-actions · 2025-01-31T23:49:38Z

📊 Benchmark results

Comparing with 8a51e34

Dependency count: 1,192 ⬆️ 1.85% increase vs. 8a51e34
Package size: 306 MB ⬇️ 3.09% decrease vs. 8a51e34
Number of ts-expect-error directives: 801 ⬇️ 0.37% decrease vs. 8a51e34

There's some sort of undocumented breaking visual change that's messing with snapshot tests.

serhalp · 2025-02-04T15:40:05Z

package.json

@@ -70,7 +70,7 @@
    "prettier": "--ignore-path .eslintignore --loglevel=warn \"{src,tools,scripts,tests,.github}/**/*.{mjs,cjs,js,mts,md,yml,json,html,ts}\" \"*.{mjs,cjs,js,mts,yml,json,html,ts}\" \".*.{mjs,cjs,js,yml,json,html,ts}\" \"!CHANGELOG.md\" \"!**/*/package-lock.json\" \"!.github/**/*.md\""
  },
  "dependencies": {
-    "@bugsnag/js": "7.25.0",
+    "@bugsnag/js": "8.2.0",


nothing relevant: https://github.com/bugsnag/bugsnag-js/blob/v8.0.0/UPGRADING.md

serhalp · 2025-02-04T15:41:16Z

package.json

@@ -82,25 +82,25 @@
    "@netlify/local-functions-proxy": "1.1.1",
    "@netlify/redirect-parser": "14.5.0",
    "@netlify/zip-it-and-ship-it": "9.42.4",
-    "@octokit/rest": "20.1.1",
+    "@octokit/rest": "21.1.0",


changed to esm: https://github.com/octokit/rest.js/releases/tag/v21.0.0

serhalp · 2025-02-04T15:41:43Z

package.json

    "@opentelemetry/api": "1.8.0",
    "ansi-escapes": "7.0.0",
    "ansi-to-html": "0.7.2",
    "ascii-table": "0.0.9",
    "backoff": "2.5.0",
    "better-opn": "3.0.2",
-    "boxen": "7.1.1",
+    "boxen": "8.0.1",


now requires node 18 (we already do): https://github.com/sindresorhus/boxen/releases/tag/v8.0.0

serhalp · 2025-02-04T15:41:59Z

package.json

    "chalk": "5.4.1",
    "chokidar": "3.6.0",
    "ci-info": "4.1.0",
    "clean-deep": "3.4.0",
    "commander": "10.0.1",
    "comment-json": "4.2.5",
-    "configstore": "6.0.0",
+    "configstore": "7.0.0",


now requires node 18 (we already do): https://github.com/sindresorhus/configstore/releases/tag/v7.0.0

serhalp · 2025-02-04T15:42:38Z

package.json

    "find-up": "7.0.0",
    "flush-write-stream": "2.0.0",
    "folder-walker": "3.2.0",
    "from2-array": "0.0.4",
    "fuzzy": "0.1.3",
-    "get-port": "5.1.1",
+    "get-port": "7.1.0",


now requires node 18 (we require 18) and uses esm, plus irrelevant changes: https://github.com/sindresorhus/get-port/releases

serhalp · 2025-02-04T15:45:20Z

package.json

    "gh-release-fetch": "4.0.3",
    "git-repo-info": "2.1.1",
    "gitconfiglocal": "2.1.0",
    "http-proxy": "1.18.1",
    "http-proxy-middleware": "2.0.7",
    "https-proxy-agent": "7.0.6",
-    "inquirer": "6.5.2",
-    "inquirer-autocomplete-prompt": "1.4.0",
+    "inquirer": "9.1.0",


inquirer 7 drops node 6: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%407.0.0

inquirer 8 drops node 10: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%408.0.0

inquirer 9 becomes esm: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%409.0.0

I had to pin to 9.0.0 because there were undocumented arguably-breaking changes to the output and updating our snapshot tests was turning into a can of worms.

To be clear, the latest is 12. 10, 11, and 12 should be easy enough in theory, if we stick with inquirer:

10 no longer needs @types/inquirer: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%4010.0.0

11 makes a styling change: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%4011.0.0

12 won't matter: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%4012.0.0

serhalp · 2025-02-04T15:49:49Z

package.json

-    "inquirer": "6.5.2",
-    "inquirer-autocomplete-prompt": "1.4.0",
+    "inquirer": "9.1.0",
+    "inquirer-autocomplete-prompt": "3.0.1",


changed to esm and supports inquirer >= 9: https://github.com/mokkabonna/inquirer-autocomplete-prompt/releases

ugh, after going down a rat hole I ended backing out of the inquirer-autocomplete-prompt upgrade since I couldn't figure what was changing and why... which in turn forced me to downscale the inquirer upgrade to v8 😞

serhalp · 2025-02-04T15:50:16Z

package.json

@@ -138,7 +138,7 @@
    "lambda-local": "2.2.0",
    "locate-path": "7.2.0",
    "lodash": "4.17.21",
-    "log-symbols": "6.0.0",
+    "log-symbols": "7.0.0",


not really major, should just become smaller: https://github.com/sindresorhus/log-symbols/releases

serhalp · 2025-02-04T15:50:44Z

package.json

@@ -155,9 +155,9 @@
    "parse-gitignore": "2.0.0",
    "prettyjson": "1.2.5",
    "pump": "3.0.2",
-    "raw-body": "2.5.2",
+    "raw-body": "3.0.0",


lousy release notes but doesn't seem actually major... https://github.com/stream-utils/raw-body/blob/master/HISTORY.md

serhalp · 2025-02-04T15:55:33Z

package.json

    "read-package-up": "11.0.0",
-    "readdirp": "3.6.0",
+    "readdirp": "4.1.1",


requires node 14, removes glob support (we weren't using them), and changes some exports (I updated our imports): https://github.com/paulmillr/readdirp/releases/tag/4.0.0

serhalp · 2025-02-04T15:56:17Z

package.json

@@ -171,11 +171,11 @@
    "ulid": "2.3.0",
    "unixify": "1.0.0",
    "update-notifier": "7.3.1",
-    "uuid": "9.0.1",
+    "uuid": "11.0.5",


requires node 16, adds types (no longer need @types/uuid): https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md

serhalp · 2025-02-04T15:57:25Z

package.json

    "@types/ws": "8.5.14",
    "@vitest/coverage-v8": "1.6.0",
-    "c8": "9.1.0",
+    "c8": "10.1.3",


requires node 18 (so do we): https://github.com/bcoe/c8/releases/tag/v10.0.0

serhalp · 2025-02-04T15:58:54Z

package.json

-    "husky": "8.0.3",
-    "is-ci": "3.0.1",
+    "fs-extra": "11.3.0",
+    "husky": "9.1.7",


requires node 18 (so do we), technically no other breaking changes but I updated to the new format: https://github.com/typicode/husky/releases/tag/v9.0.1

serhalp · 2025-02-04T15:59:41Z

package.json

-    "is-ci": "3.0.1",
+    "fs-extra": "11.3.0",
+    "husky": "9.1.7",
+    "is-ci": "4.1.0",


removes support for very minor CI platforms: https://github.com/watson/is-ci/releases/tag/v4.0.0

serhalp · 2025-02-04T19:42:39Z

package.json

    "cheerio": "1.0.0",
    "eslint-plugin-sort-destructure-keys": "2.0.0",
    "eslint-plugin-workspace": "file:./tools/lint-rules",
    "form-data": "4.0.1",
-    "fs-extra": "11.2.0",


unrelated but this was easy to get rid of so I did (just a dev dep, so won't help with package weight, but still)

pulled out into #7025

It looks like there's some sort of change in inquirer-autocomplete-prompt and it's a can of worms to troubleshoot. This in turn prevents upgrading inquirer past v8.

serhalp · 2025-02-04T21:01:34Z

package.json

    "gh-release-fetch": "4.0.3",
    "git-repo-info": "2.1.1",
    "gitconfiglocal": "2.1.0",
    "http-proxy": "1.18.1",
    "http-proxy-middleware": "2.0.7",
    "https-proxy-agent": "7.0.6",
-    "inquirer": "6.5.2",
+    "inquirer": "8.0.0",


GitHub hid the comments: #7019 (comment)

serhalp · 2025-02-04T21:02:40Z

package.json

-    "nock": "13.5.6",
+    "husky": "9.1.7",
+    "is-ci": "4.1.0",
+    "nock": "14.0.0",


requires node 18 (like we do): https://github.com/nock/nock/releases/tag/v14.0.0

This reverts commit 055a7b0.

ndhoule

serhalp force-pushed the fix/upgrade-misc-deps-except-commander branch 3 times, most recently from 6413ed5 to a964464 Compare February 3, 2025 14:41

serhalp added 2 commits February 4, 2025 10:30

fix(deps): upgrade 19 outdated dependencies

e94ccf4

fix(deps): pin inquirer to earlier patch

8da2278

There's some sort of undocumented breaking visual change that's messing with snapshot tests.

serhalp force-pushed the fix/upgrade-misc-deps-except-commander branch from a964464 to 8da2278 Compare February 4, 2025 15:30

serhalp commented Feb 4, 2025

View reviewed changes

serhalp force-pushed the fix/upgrade-misc-deps-except-commander branch 2 times, most recently from 6f9ed61 to b4b7532 Compare February 4, 2025 20:03

serhalp added 3 commits February 4, 2025 15:56

chore(deps): remove 2 unnecessary dev deps

055a7b0

fix: pin inquirer modules again

9986480

It looks like there's some sort of change in inquirer-autocomplete-prompt and it's a can of worms to troubleshoot. This in turn prevents upgrading inquirer past v8.

fix(deps): bump more dependencies

2eb463a

serhalp force-pushed the fix/upgrade-misc-deps-except-commander branch from b4b7532 to 2eb463a Compare February 4, 2025 20:56

serhalp commented Feb 4, 2025

View reviewed changes

serhalp changed the title ~~fix(deps): upgrade 19 outdated dependencies~~ fix(deps): upgrade 23 outdated dependencies Feb 4, 2025

Revert "chore(deps): remove 2 unnecessary dev deps"

5e4b8fc

This reverts commit 055a7b0.

serhalp mentioned this pull request Feb 4, 2025

fix(deps): upgrade commander #7008

Draft

serhalp marked this pull request as ready for review February 4, 2025 23:14

serhalp requested a review from a team as a code owner February 4, 2025 23:14

ndhoule approved these changes Feb 6, 2025

View reviewed changes

serhalp merged commit f74c6c6 into main Feb 6, 2025
49 checks passed

serhalp deleted the fix/upgrade-misc-deps-except-commander branch February 6, 2025 00:03

token-generator-app bot mentioned this pull request Feb 6, 2025

chore(main): release 18.0.4 #7028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): upgrade 23 outdated dependencies #7019

fix(deps): upgrade 23 outdated dependencies #7019

serhalp commented Jan 31, 2025

github-actions bot commented Jan 31, 2025 •

edited

Loading

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025 •

edited

Loading

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

serhalp Feb 4, 2025

ndhoule left a comment

fix(deps): upgrade 23 outdated dependencies #7019

fix(deps): upgrade 23 outdated dependencies #7019

Conversation

serhalp commented Jan 31, 2025

Summary

github-actions bot commented Jan 31, 2025 • edited Loading

📊 Benchmark results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serhalp Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndhoule left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 31, 2025 •

edited

Loading

serhalp Feb 4, 2025 •

edited

Loading