feat: port in use #6887
Merged
feat: port in use #6887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nforms the user that this could be from a netlify function opening ports Co-authored-by: Thomas Lane <[email protected]>
Co-authored-by: Thomas Lane <[email protected]>
DanielSLew
requested changes
Oct 19, 2024
Co-authored-by: Will <[email protected]>
|
This has been updated with a new type. |
DanielSLew
reviewed
Oct 23, 2024
DanielSLew
previously approved these changes
Oct 28, 2024
auto-merge was automatically disabled
October 30, 2024 17:52
Head branch was pushed to by a user without write access
wconrad265
force-pushed
the
port-in-use
branch
from
5d92bbe to
34b6bb4
Compare
|
The tests have been fixed. Ready for re-review |
|
Look like this might be a flakey test. It passed in every single other environment, and passes the test locally. The tests were passing until I merged the latest version of main. |
DanielSLew
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This pull request addresses these issues found below
netlify dev#6840We (@tlane25) outline the problem in the comments in #6840.
This pull request adds better error handling for users who open a port for a serverless function.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)