test: add CLI timeout #1727
Merged
test: add CLI timeout #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
added
the
type: chore
ehmicky
reviewed
Jan 13, 2021
tests/utils/call-cli.js
Outdated
| const callCli = async function (args, execOptions) { | ||
| const { stdout } = await execa(cliPath, args, { windowsHide: true, windowsVerbatimArguments: true, ...execOptions }) | ||
| const { stdout } = await execa(cliPath, args, { | ||
| windowsHide: true, |
There was a problem hiding this comment.
This is already the default value.
Note: windowsHide is a tricky option which has pros and cons. We probably want to keep the default value here and let Execa decides what the best value for it is.
There was a problem hiding this comment.
Removed in 130ee48
ehmicky
reviewed
Jan 13, 2021
tests/utils/call-cli.js
Outdated
| const { stdout } = await execa(cliPath, args, { windowsHide: true, windowsVerbatimArguments: true, ...execOptions }) | ||
| const { stdout } = await execa(cliPath, args, { | ||
| windowsHide: true, | ||
| windowsVerbatimArguments: true, |
There was a problem hiding this comment.
Is this needed? Would the default behavior might be better at handling Windows?
There was a problem hiding this comment.
Don't think it is. Removed in 130ee48
ehmicky
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a timeout of 30 seconds for CLI invocations in our tests.