test(command-dev): limit concurrency #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
added
the
type: chore
erezrokah
force-pushed
the
chore/limit_dev_tests
branch
from
4316f4c to
471df22
Compare
|
@ehmicky this doesn't solve all our CI issues, but looks like it doesn't impact performance: |
ehmicky
reviewed
Jan 11, 2021
tests/command.dev.test.js
Outdated
| @@ -14,6 +15,9 @@ const { withDevServer } = require('./utils/dev-server') | |||
| const { startExternalServer } = require('./utils/external-server') | |||
| const { withSiteBuilder } = require('./utils/site-builder') | |||
|
|
|||
| const CONCURRENCY = 1 | |||
| const semaphore = process.env.CI === 'true' ? new Semaphore(CONCURRENCY) : null | |||
There was a problem hiding this comment.
Would the following work too?
const testFunc = process.env.CI === 'true' ? test.serial.bind(test) : test
testFunct('test title', (t) => { ... })There was a problem hiding this comment.
You're right, I was playing with different values or CONCURRENCY (4->2->1).
We can remove the dependency and enforce serial.
There was a problem hiding this comment.
I chose to do it a bit different. It required disabling a lint rule, but makes the spec consistent with other ones.
Please let me know if you're good with it.
erezrokah
force-pushed
the
chore/limit_dev_tests
branch
from
471df22 to
a9cf81a
Compare
ehmicky
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make our CI more stable by limiting the concurrency of the servers we spawn during tests.