Skip to content

feat: add SolidStart 2.x support - #7156

Merged
serhalp merged 2 commits into
mainfrom
serhalp/feat/solidstart-2
Aug 6, 2026
Merged

feat: add SolidStart 2.x support#7156
serhalp merged 2 commits into
mainfrom
serhalp/feat/solidstart-2

Conversation

@serhalp

@serhalp serhalp commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

SolidStart 2.0 was released yesterday. See https://docs.solidjs.com/solid-start/v2/migrating-from-v1 for v1 to v2 differences (although note the 3000 → 5173 dev port change is not mentioned).

This PR adds detection and configuration of SolidStart 2.x projects.

@serhalp
serhalp requested a review from a team as a code owner August 6, 2026 00:04
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 487a0c3a-59b2-4b43-a8f6-992ff42fabdb

📥 Commits

Reviewing files that changed from the base of the PR and between f34dd81 and 847d8b1.

📒 Files selected for processing (2)
  • packages/build-info/src/frameworks/solid-start.test.ts
  • packages/build-info/src/frameworks/solid-start.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated SolidStart project detection to support both v1 and v2 configurations.
    • Correctly identifies Vite-based SolidStart v2 projects, including Netlify’s Vite plugin.
    • Applies the appropriate development port, build commands, and output directory for each SolidStart version.

Walkthrough

SolidStart defaults now use Vite development on port 5173 and build output in dist/client. Detected SolidStart versions before v2 retain Vinxi commands, port 3000, and the dist directory. Tests identify the v1 fixture explicitly and add coverage for SolidStart v2 projects using @solidjs/start 2.x, Vite configuration, and Netlify’s Vite plugin.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: pieh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: adding SolidStart 2.x support.
Description check ✅ Passed The description explains the motivation and scope of the SolidStart 2.x detection and configuration changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch serhalp/feat/solidstart-2

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

e18e dependency analysis

No dependency warnings found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 847d8b160a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/build-info/src/frameworks/solid-start.ts
@pkg-pr-new

pkg-pr-new Bot commented Aug 6, 2026

Copy link
Copy Markdown

Open in StackBlitz

@netlify/build

npm i https://pkg.pr.new/@netlify/build@7156

@netlify/build-info

npm i https://pkg.pr.new/@netlify/build-info@7156

@netlify/cache-utils

npm i https://pkg.pr.new/@netlify/cache-utils@7156

@netlify/config

npm i https://pkg.pr.new/@netlify/config@7156

@netlify/edge-bundler

npm i https://pkg.pr.new/@netlify/edge-bundler@7156

@netlify/functions-utils

npm i https://pkg.pr.new/@netlify/functions-utils@7156

@netlify/git-utils

npm i https://pkg.pr.new/@netlify/git-utils@7156

@netlify/headers-parser

npm i https://pkg.pr.new/@netlify/headers-parser@7156

@netlify/api

npm i https://pkg.pr.new/@netlify/api@7156

@netlify/nock-udp

npm i https://pkg.pr.new/@netlify/nock-udp@7156

@netlify/opentelemetry-sdk-setup

npm i https://pkg.pr.new/@netlify/opentelemetry-sdk-setup@7156

@netlify/opentelemetry-utils

npm i https://pkg.pr.new/@netlify/opentelemetry-utils@7156

@netlify/redirect-parser

npm i https://pkg.pr.new/@netlify/redirect-parser@7156

@netlify/run-utils

npm i https://pkg.pr.new/@netlify/run-utils@7156

@netlify/zip-it-and-ship-it

npm i https://pkg.pr.new/@netlify/zip-it-and-ship-it@7156

commit: 4451315

@serhalp
serhalp enabled auto-merge (squash) August 6, 2026 09:58
@serhalp
serhalp merged commit 4319497 into main Aug 6, 2026
62 of 63 checks passed
@serhalp
serhalp deleted the serhalp/feat/solidstart-2 branch August 6, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants