Skip to content

fix: honor edge functions configuration in frameworks api config - #7125

Merged
hrishikesh-k merged 6 commits into
mainfrom
michalpiechowiak/frb-2307-frameworks-api-is-not-honoring
Jul 20, 2026
Merged

fix: honor edge functions configuration in frameworks api config#7125
hrishikesh-k merged 6 commits into
mainfrom
michalpiechowiak/frb-2307-frameworks-api-is-not-honoring

Conversation

@pieh

@pieh pieh commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes https://linear.app/netlify/issue/FRB-2307/frameworks-api-is-not-honoring-netifyv1configjsonedge-functions


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds shared edge function property definitions and origin-specific validation, allowing name in user configuration while reserving generator. Frameworks API filtering now passes through edge_functions, and declaration merging collects metadata across matching declarations. New fixtures and tests verify routing, exclusions, metadata precedence, generated configuration, and validation behavior.

Estimated code review effort: 3 (Moderate) | ~25 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: honoring edge functions configuration in the Frameworks API.
Description check ✅ Passed The description includes the required Summary and checklist sections and is mostly complete for this repository.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch michalpiechowiak/frb-2307-frameworks-api-is-not-honoring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

e18e dependency analysis

No dependency warnings found.

@pkg-pr-new

pkg-pr-new Bot commented Jul 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

@netlify/build

npm i https://pkg.pr.new/@netlify/build@7125

@netlify/build-info

npm i https://pkg.pr.new/@netlify/build-info@7125

@netlify/cache-utils

npm i https://pkg.pr.new/@netlify/cache-utils@7125

@netlify/config

npm i https://pkg.pr.new/@netlify/config@7125

@netlify/edge-bundler

npm i https://pkg.pr.new/@netlify/edge-bundler@7125

@netlify/functions-utils

npm i https://pkg.pr.new/@netlify/functions-utils@7125

@netlify/git-utils

npm i https://pkg.pr.new/@netlify/git-utils@7125

@netlify/headers-parser

npm i https://pkg.pr.new/@netlify/headers-parser@7125

@netlify/api

npm i https://pkg.pr.new/@netlify/api@7125

@netlify/nock-udp

npm i https://pkg.pr.new/@netlify/nock-udp@7125

@netlify/opentelemetry-sdk-setup

npm i https://pkg.pr.new/@netlify/opentelemetry-sdk-setup@7125

@netlify/opentelemetry-utils

npm i https://pkg.pr.new/@netlify/opentelemetry-utils@7125

@netlify/redirect-parser

npm i https://pkg.pr.new/@netlify/redirect-parser@7125

@netlify/run-utils

npm i https://pkg.pr.new/@netlify/run-utils@7125

@netlify/zip-it-and-ship-it

npm i https://pkg.pr.new/@netlify/zip-it-and-ship-it@7125

commit: 055746b

@hrishikesh-k
hrishikesh-k marked this pull request as ready for review July 20, 2026 16:56
@hrishikesh-k
hrishikesh-k requested a review from a team as a code owner July 20, 2026 16:56
@hrishikesh-k hrishikesh-k changed the title test: add tests for honoring edge functions configuration in frameworks api config fix: honor edge functions configuration in frameworks api config Jul 20, 2026
@hrishikesh-k
hrishikesh-k merged commit bca93db into main Jul 20, 2026
62 of 64 checks passed
@hrishikesh-k
hrishikesh-k deleted the michalpiechowiak/frb-2307-frameworks-api-is-not-honoring branch July 20, 2026 18:31
yurishkuro pushed a commit to jaegertracing/documentation that referenced this pull request Aug 12, 2026
This PR contains the following updates:

| Package | Change |
[Age](https://docs.renovatebot.com/merge-confidence/) |
[Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [netlify-cli](https://github.com/netlify/cli) | [`^23.13.4
\|\| ^24.0.0 \|\| ^26.0.0` → `^23.13.4 \|\| ^24.0.0 \|\| ^26.0.0 \|\|
^27.0.0`](https://renovatebot.com/diffs/npm/netlify-cli/26.2.0/27.1.1) |
![age](https://developer.mend.io/api/mc/badges/age/npm/netlify-cli/27.1.1?slim=true)
|
![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/netlify-cli/26.2.0/27.1.1?slim=true)
|

---

### Release Notes

<details>
<summary>netlify/cli (netlify-cli)</summary>

###
[`v27.1.1`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#2711-2026-08-07)

[Compare
Source](https://github.com/netlify/cli/compare/v27.1.0...v27.1.1)

##### Bug Fixes

- **deps:** update netlify packages
([#&#8203;8393](https://github.com/netlify/cli/issues/8393))
([4bb0d91](https://github.com/netlify/cli/commit/4bb0d914d1b4ef5bc2459c4561ee1d2e2eef3d86))
  - This includes a fix for npm 12 for projects with Netlify Extensions.

###
[`v27.1.0`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#2710-2026-08-04)

[Compare
Source](https://github.com/netlify/cli/compare/v27.0.3...v27.1.0)

##### Features

- new edge function upload
([#&#8203;8326](https://github.com/netlify/cli/issues/8326))
([3f33c36](https://github.com/netlify/cli/commit/3f33c363d3ffbf43f4c57604ea6e00782eca1819))

##### Bug Fixes

- reconstruct build\_data when missing on direct-zip deploys
([#&#8203;8353](https://github.com/netlify/cli/issues/8353))
([3b52aa0](https://github.com/netlify/cli/commit/3b52aa078e232692793bf24b4077ab4c5ace009e))

###
[`v27.0.3`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#2703-2026-08-04)

[Compare
Source](https://github.com/netlify/cli/compare/v27.0.2...v27.0.3)

##### Bug Fixes

- prevent file descriptor exhaustion when watching for EF changes
([#&#8203;8387](https://github.com/netlify/cli/issues/8387))
([15f20fa](https://github.com/netlify/cli/commit/15f20fa81cca07aa799ed3bb3d0ad01cc84cfad9))

###
[`v27.0.2`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#2702-2026-08-03)

[Compare
Source](https://github.com/netlify/cli/compare/v27.0.1...v27.0.2)

##### Bug Fixes

- **deps:** update dependency modern-tar to v0.7.6
([#&#8203;8159](https://github.com/netlify/cli/issues/8159))
([13397d3](https://github.com/netlify/cli/commit/13397d3637f34d9d8f49f34b7d46361fc38af6a0))
- **deps:** update netlify packages
([#&#8203;8388](https://github.com/netlify/cli/issues/8388))
([f29b112](https://github.com/netlify/cli/commit/f29b1128c00abd0de4da92660237d37ea92c4dfb))

###
[`v27.0.1`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#2701-2026-07-27)

[Compare
Source](https://github.com/netlify/cli/compare/v27.0.0...v27.0.1)

##### Bug Fixes

- allow --site-id as a silent flag to prevent common guessing mistakes
from agents
([#&#8203;8180](https://github.com/netlify/cli/issues/8180))
([4984c3c](https://github.com/netlify/cli/commit/4984c3c66169f80f31063fc9a3d1bab50c217d45))
- **api:** teach instead of leaking SyntaxError on malformed --data
([#&#8203;8333](https://github.com/netlify/cli/issues/8333))
([6e0298c](https://github.com/netlify/cli/commit/6e0298c82852bf67c2adcc76268c384fb20ae81e))
- **deps:** update dependency
[@&#8203;netlify/blobs](https://github.com/netlify/blobs) to
^10.7.10
([#&#8203;8375](https://github.com/netlify/cli/issues/8375))
([3bc357a](https://github.com/netlify/cli/commit/3bc357ad8be5e9bfc56f94360c752728a5a3bbb6))
- **deps:** update dependency
[@&#8203;netlify/images](https://github.com/netlify/images) to
^1.3.11
([#&#8203;8376](https://github.com/netlify/cli/issues/8376))
([e0ebaf5](https://github.com/netlify/cli/commit/e0ebaf583b689b1fe98484b36af4530f19686dd3))
- **deps:** update dependency readdirp to v5
([#&#8203;8012](https://github.com/netlify/cli/issues/8012))
([12645a8](https://github.com/netlify/cli/commit/12645a85c333318d61df0f39b4a4d66c24065ad7))
- **deps:** update netlify packages (major)
([#&#8203;8322](https://github.com/netlify/cli/issues/8322))
([0d36749](https://github.com/netlify/cli/commit/0d36749c49ac9293e855ffb019b7793fbdf5610a))
- [Vite Plus](https://viteplus.dev/) projects are now detected and
configured automatically:
[netlify/build#7128](https://github.com/netlify/build/pull/7128)
- Fixes a bug in the [Frameworks
API](https://docs.netlify.com/build/frameworks/frameworks-api/) where
`.netlify/v1/config.json#edge_functions` was not respected:
[netlify/build#7125](https://github.com/netlify/build/pull/7125)

###
[`v27.0.0`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#2700-2026-07-24)

[Compare
Source](https://github.com/netlify/cli/compare/v26.2.0...v27.0.0)

##### ⚠ BREAKING CHANGES

- **cli:** document exit codes, usage errors use exit code 2
([#&#8203;8329](https://github.com/netlify/cli/issues/8329))
- drop support for Node.js 20, require 22.13.0+
([#&#8203;8356](https://github.com/netlify/cli/issues/8356))

##### Features

- **cli:** document exit codes, usage errors use exit code 2
([#&#8203;8329](https://github.com/netlify/cli/issues/8329))
([9098467](https://github.com/netlify/cli/commit/90984676f4182e6c94b3bcce7f603b86eb271240))
- drop support for Node.js 20, require 22.13.0+
([#&#8203;8356](https://github.com/netlify/cli/issues/8356))
([8943e38](https://github.com/netlify/cli/commit/8943e386e0d1f21e62858e993546eea763c13dbb))

##### Bug Fixes

- **cli:** piped --help no longer glues flag names to descriptions
([#&#8203;8330](https://github.com/netlify/cli/issues/8330))
([4b87cc7](https://github.com/netlify/cli/commit/4b87cc7d92ba170379090bbd9e5617d9afedf9b1))
- **init:** fix handling of gitlab repos
([#&#8203;7945](https://github.com/netlify/cli/issues/7945))
([f214e69](https://github.com/netlify/cli/commit/f214e69e4d8b0d3ab0db2ed79e612873d7c09d43))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/jaegertracing/documentation).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yODAuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjI0LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImNoYW5nZWxvZzpkZXBlbmRlbmNpZXMiXX0=-->

Signed-off-by: Mend Renovate <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants