-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift Package Manager support #64
Conversation
9f29900
to
6e42aa5
Compare
6e42aa5
to
653eebc
Compare
@akashivskyy could you take a look a this when you get a chance? |
Thanks for your contribution, Matt! Unfortunately, I'm no longer a maintainer of this project. I'm sure @Siemian will know someone who can help you get this PR sorted. Cheers! 🙌 |
Hi @mattboran, thank you for your contribution, i was testing your changes using Xcode 13 and unfortunately, it does not compile properly. Here is what i got: Thanks @akashivskyy for the ping! |
@Siemian thanks for taking a look! It looks like I had configured the header paths incorrectly. I have added some additional build settings to the internal Objective-C target. Now, using Xcode 13.0:
Please let me know if you're seeing something different on your end! Edit: |
Bumping this thread @Siemian 🙂 |
Hi @mattboran i'm really really sorry for keep you waiting for such a long time. I checked and looks ok now, thanks for your contribution 🙇 |
This PR adds support for Swift Package manager to this repository.
The same versions of iOS, macOS, and tvOS are supported as before, and the project structure was not changed. This means that the Carthage and CocoaPods versions of this framework still work.
I had to make 2 small changes in
ResponseDetectiveSpec.swift
:buffer
is initialized newly in thebeforeEach
block. Otherwise, running tests in a random order can failstub(condition: isHost...
withHTTPStubs.stubRequests
; it's possible I configured something incorrectly, but my Swift compiler was unable to find that method.Please let me know what you think!