Add handler for peripheral connection cancelled #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add public `peripheralConnectionCancelledHandler(_:)` settable property - refactor from `.filter(_:).first` to `first(where:)` for optimisation - bump version to 1.0.6 - add project change log
dymb
approved these changes
Apr 8, 2022
| @@ -76,7 +82,7 @@ extension ConnectionService { | |||
| /// Disconnects given device. | |||
| internal func disconnect(_ peripheral: CBPeripheral) { | |||
| if let index = peripherals.firstIndex(where: { $0.peripheral === peripheral }) { | |||
| peripherals.remove(at: index) | |||
| peripheralsToDisconnect.append(peripherals.remove(at: index)) | |||
There was a problem hiding this comment.
WDYT to extract peripherals.remove(at: index) to separate variable which could be more readable what is actually going on in here.
| /// `error` is nil if disconnect resulted from a call to `cancelPeripheralConnection(_:)`. | ||
| /// SeeAlso: https://developer.apple.com/documentation/corebluetooth/cbcentralmanagerdelegate/1518791-centralmanager | ||
| if error == nil, | ||
| let disconnectedPeripheral = peripheralsToDisconnect.first(where: { $0.peripheral === peripheral }) { |
There was a problem hiding this comment.
peripheralsToDisconnect.first(where: { $0.peripheral === peripheral }) is called twice. WDYT to extract it to separate variable which cloud be used in both ifs ? :)
added 2 commits
April 10, 2022 12:40
…nce with `peripheral` property identical to given `CBPeripheral` instance
filip-zielinski
deleted the
Add-handler-for-connection-cancelled-manually
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add handler for peripheral connection cancelled.
Motivation
A project I'm working on needs to be notified when disconnecting a peripheral completes (so after calling
disconnect(_:), when CoreBluetooth completes disconnecting).Task Description
peripheralConnectionCancelledHandler(_:)settable property.filter(_:).firsttofirst(where:)for optimization